starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-26 01:06:00 +03:00

[GH-ISSUE #436] Bug: Sort by length #311

New issue

Closed

opened 2026-02-26 02:32:47 +03:00 by kerem · 3 comments

kerem commented

2026-02-26 02:32:47 +03:00

Owner

Originally created by @BernardGoldberger on GitHub (Sep 5, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/436

Windows Master, Opera.

Sorting by fmtLength works, to change the sorting, but the display of the fmtLength for each song does not change.

I noticed that removing the v-once bind from song-item.vue line 20 resolves it.

Did not submit a PR cause I figured there is some use for it.

Below are some screen shots, notice how the sorting changes but not the time.

No sorting

Descending

Ascending

Originally created by @BernardGoldberger on GitHub (Sep 5, 2016). Original GitHub issue: https://github.com/koel/koel/issues/436 Windows Master, Opera. Sorting by `fmtLength` works, to change the sorting, but the display of the `fmtLength` for each song does not change. I noticed that removing the `v-once` bind from [`song-item.vue` line 20](https://github.com/phanan/koel/blob/master/resources/assets/js/components/shared/song-item.vue#L20) resolves it. Did not submit a PR cause I figured there is some use for it. Below are some screen shots, notice how the sorting changes but not the time. No sorting ![image](https://cloud.githubusercontent.com/assets/10334679/18259364/3958febc-73b1-11e6-9f12-57c9ba51f4f2.png) Descending ![image](https://cloud.githubusercontent.com/assets/10334679/18259370/4d0c24c0-73b1-11e6-8a59-0445c3e932ca.png) Ascending ![image](https://cloud.githubusercontent.com/assets/10334679/18259389/6dca37e2-73b1-11e6-9201-218d87e3c49a.png)

kerem closed this issue

2026-02-26 02:32:48 +03:00

kerem commented

2026-02-26 02:32:48 +03:00

Author

Owner

@phanan commented on GitHub (Sep 6, 2016):

v-once is just some (premature) optimization, and is safe to be removed. Can you please do and submit the PR over? Thanks!

@phanan commented on GitHub (Sep 6, 2016): `v-once` is just some (premature) optimization, and is safe to be removed. Can you please do and submit the PR over? Thanks!

kerem commented

2026-02-26 02:32:48 +03:00

Author

Owner

@phanan commented on GitHub (Sep 6, 2016):

That said, is this a Vue's bug instead? I'll ask the team.

@phanan commented on GitHub (Sep 6, 2016): That said, is this a Vue's bug instead? I'll ask the team.

kerem commented

2026-02-26 02:32:48 +03:00

Author

Owner

@BernardGoldberger commented on GitHub (Sep 6, 2016):

I would think it is.

@BernardGoldberger commented on GitHub (Sep 6, 2016): I would think it is.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#311

No description provided.

Rows
Columns