mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #435] Use system font #307
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#307
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @phanan on GitHub (Sep 5, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/435
Right now Koel is using Roboto of various font weights. There's nothing wrong with that, but maybe we can just use the system font instead:
The above CSS rule will use the default OS font. On OS X El Capitan for instance, the font is San Francisco, and the interface will look like this:
…which is not bad, especially considering hundreds of KBs of Roboto less to load and the native multi-byte support.
@BernardGoldberger commented on GitHub (Sep 6, 2016):
I assuming that this will result in Koel loading faster, I would like to give a test, is
what I need to do in Windows as well?
@phanan commented on GitHub (Sep 7, 2016):
@bdgold You don't need to do anything. That rule works cross-OS.
Others: Please explain the thumbs down if you could, thanks!
@BernardGoldberger commented on GitHub (Sep 18, 2016):
Doesn't look very good on my system Windows, opera.
Notice the following letters and numbers S, 2 and 5.
@phanan commented on GitHub (Sep 18, 2016):
It's subjective… I'd prefer system fonts any day.
On Mon, Sep 19, 2016 at 12:06 AM, bdgold notifications@github.com wrote:
@phanan commented on GitHub (Sep 18, 2016):
Will
font-size: normallook better?@BernardGoldberger commented on GitHub (Sep 18, 2016):
No
@phanan commented on GitHub (Sep 19, 2016):
Hm… I'm more concerned about the YouTube button on the right. Is it always like that (dropped to a new line)?
@BernardGoldberger commented on GitHub (Sep 19, 2016):
No. Its the bigger [normal] font size, that is also the cause for the heading being so large.
@phanan commented on GitHub (Sep 19, 2016):
Shouldn't be. This is a screenshot of my Webkit, Windows 7:
@phanan commented on GitHub (Sep 19, 2016):
Oh, I get what you mean now. Well, Windows font rendering is known to be inferior to that of OS X :P
@BernardGoldberger commented on GitHub (Sep 21, 2016):
So I did some digging and found this and basically it turns out that the issue is the font weight is set to 300, I went ahead and upped it to 400 which is
normaland here is the resultnote hoe the meta info is still an issue, but who cares?
It looks much better... however now the white font was too much to handle so I changed
$colorMainTexttoe7e7e7which makes it a little easier on the eyes, see imageI don't know how these changes will behave in other systems, let me know what you think.
Firefox in windows also looks great with these changes.
@phanan commented on GitHub (Sep 22, 2016):
Thanks for the findings. Let me try them on Mac.
On Thu, Sep 22, 2016 at 4:43 AM, bdgold notifications@github.com wrote: