mirror of
https://github.com/koel/koel.git
synced 2026-04-29 10:45:59 +03:00
[GH-ISSUE #422] 1000 song limit in playlists #299
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#299
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ronilaukkarinen on GitHub (Aug 24, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/422
Added whole lot of a songs to a playlist, but after I rescanned my library, I had exactly 1000 songs on the playlist. Before there were over 7000 songs on that list. Does koel have some limit?
Version: Koel 3.3.0
Screenshot
@BernardGoldberger commented on GitHub (Aug 24, 2016):
I have playlists with more than 1,000 songs.
I would say that for some reason it seems like the songs have gotten a new ID when you scanned them again, to test this you can do the following, filter the playlist id in the
playlist_songtable in your DB, and check how many rows there are.@phanan commented on GitHub (Aug 26, 2016):
No, Koel doesn't have such a limitation. Can you try what @bdgold said and see how many rows there are in the DB?
@ronilaukkarinen commented on GitHub (Sep 15, 2016):
Sorry for this taking so long, been busy... I have 2243 rows in
playlist_song. But still seeing exactly 1000 in the front end side. It doesn't grow if I add a song.@BernardGoldberger commented on GitHub (Sep 15, 2016):
It might sound like a stupid question, but how do know it only lists 1,000 songs? is it because the stat says so? or did you go to check if a recent added song is there?
@ronilaukkarinen commented on GitHub (Sep 15, 2016):
Good question! why I didn't check that before, I don't know... just assumed. Yes, they show up when I use search. And in fact, the number updates when I add the songs, but when I remove them, it shows 1001. Something wrong with the number.
@BernardGoldberger commented on GitHub (Sep 15, 2016):
Does the issue repeat itself with new playlists?
@phanan commented on GitHub (Sep 15, 2016):
That's weird :D Can you record a gif?
On Thu, Sep 15, 2016 at 8:10 PM, bdgold notifications@github.com wrote:
@BernardGoldberger commented on GitHub (Sep 15, 2016):
Remove? how do you remove a song from a playlist?
@phanan commented on GitHub (Sep 15, 2016):
You press Delete?
On Thu, Sep 15, 2016 at 9:21 PM, bdgold notifications@github.com wrote:
@BernardGoldberger commented on GitHub (Sep 15, 2016):
Thats to delete the playlist, not to remove a song from the playlist.
@BernardGoldberger commented on GitHub (Sep 15, 2016):
Oh, I see, I have to use the keyboard Del key.
Should probably put in a feature request.
@phanan commented on GitHub (Sep 15, 2016):
No? You can select songs in the playlist and press Delete normally.
On Thu, Sep 15, 2016 at 9:27 PM, bdgold notifications@github.com wrote:
@BernardGoldberger commented on GitHub (Sep 15, 2016):
@phanan, I just did some tests on the playlists including favorites and noticed that there are some major bugs when selecting the song within the playlist, might be related or unrelated to the users issue.
Whenever sorting is changed in a playlist selecting becomes messed up, I attached a gif [it a long gif] where I do he following
If you miss it the first time don' worry, I repeat it.
@ronilaukkarinen Maybe when you are removing songs you are not actually removing them all since they are not all selected as you might have thought.
@phanan commented on GitHub (Sep 15, 2016):
@bdgold: Yes it's a known issue.
On Fri, Sep 16, 2016 at 12:36 AM, bdgold notifications@github.com wrote:
@BernardGoldberger commented on GitHub (Sep 15, 2016):
@phanan I want to clarify that this is a different issue than https://github.com/phanan/koel/issues/427, my issue does not happen in the song, album or artist view.
@phanan commented on GitHub (Sep 25, 2016):
@bdgold Sorry, I missed this. Can you report this as a separate issue? Thanks!
@ronilaukkarinen commented on GitHub (Nov 8, 2016):
This still doesn't work properly, I can't trust my playlists.
Just added 1200 songs on the list, renamed the playlist, waited a bit, refreshed the page = playlist is in the old name and all my changes are gone. I have now 724 songs on the playlist and it doesn't make any sense.
I have sometimes a quite slow Internet connection at home and koel is hosted on my home server, so that may explain the things if songs are not added in real time, for example if I add 200 songs at once? that would also explain the name not updating if it's stuck in "buffer" and doesn't complete in time before I reload the page?
Really needs optimization. For me playlists are right now useless feature.
Feature suggestion for playlists: Spotify-like ("already on the list - skip/add anyway") possible?
Thanks for the effort so far 👍 (have to give credit for the good work to not just complain and demand features... ;) )
@ronilaukkarinen commented on GitHub (Nov 8, 2016):
Oh and when I scroll the playlist, I see about 50 songs and not more regardless how much I scroll, looks like really short list. But when I shuffle them all to my play queue, I see many many songs.
@phanan commented on GitHub (Nov 8, 2016):
@ronilaukkarinen Right now songs are added into playlists without a feedback, with the assumption of a quick task. I think I'll add the "loading" (YouTube-like) for a better UX. For the second issue, does it happen with a full page reload?
@ronilaukkarinen commented on GitHub (Nov 8, 2016):
By second issue you mean name not changing, yes, with a full page reload the name often changes back to previous one (at least when I'm adding songs). If you mean only 50 songs displaying, that seemed to be temporary, full page reload helped. Thanks.
EDIT: Correction, it loads up now about 200 songs, but cannot load further... very strange.
@phanan commented on GitHub (Nov 28, 2016):
@ronilaukkarinen I've added a loading bar on top of the screen. Can you try repeating what you did and see if it's because the requests hadn't completed?
@phanan commented on GitHub (Jan 14, 2017):
Closing due to inactivity.