mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #396] Problem's transcoding FLAC #288
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#288
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alex-phillips on GitHub (Aug 8, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/396
Using the Chrome browser (up to date), I just updated my installation to the latest master branch a few hours ago. I can no longer play transcoded FLAC files with the following error appearing in my console:
I can replicate it with any of my FLAC tracks. Was working earlier today, but after the update, this problem started. Can try and look into debugging it later, but thought I'd go ahead and file an issue.
@BernardGoldberger commented on GitHub (Aug 8, 2016):
I had the same error after a force sync yesterday, but I don't believe it had anything to do with
FLACfiles, I will double check.I had the error when I ran an unsuccessful force sync with my audio files located in a new folder, but I solved everything by pointing the path to the old location.
@alex-phillips commented on GitHub (Aug 8, 2016):
@bdgold I double checked some of the files and the paths are correct in the database though. Running a force sync isn't really ideal. With 40k+ files, it takes HOURS to do a full sync.
Any information on how to fix this without running that would be awesome.
Also, unusual this issue is only on FLAC files. Everything else I've tried seems fine.
@BernardGoldberger commented on GitHub (Aug 8, 2016):
@alex-phillips
Are those music files or just files to scan?
@alex-phillips commented on GitHub (Aug 8, 2016):
Music files
@BernardGoldberger commented on GitHub (Aug 8, 2016):
Hmmmm, I had a music library with 48k songs and loading koel was a disaster, are you experiencing the same?
@alex-phillips commented on GitHub (Aug 8, 2016):
Loading koel is a disaster with my library. I wrote my own front end that is an iTunes clone (I posted a premature demo in a previous PR) and it runs as smoothly as a native app. I didn't build it to be mobile friendly though. If you're interested in trying it out let me know and I can shoot you a link. Uses koel backbend.
As far as this issue goes, this issue does occur in the official koel code and front-end.
@BernardGoldberger commented on GitHub (Aug 8, 2016):
Please do, I would like to give it a try.
@BernardGoldberger commented on GitHub (Aug 8, 2016):
Same issue by me with
FLAC@BernardGoldberger commented on GitHub (Aug 9, 2016):
I just changed
$transcode =tonulland it works again.Once it works there is still a 500 error on getting info.
Update
Even with
nullnot all are working, some still give the same error.@phanan commented on GitHub (Aug 9, 2016):
I acknowledge this. Some changes in the recent Chrome version(s?) seem to have broken transcoding-streaming. Will certainly look for a workaround when I have time.
@BernardGoldberger commented on GitHub (Aug 9, 2016):
@phanan I believe there are some breaking changes in
github.com/phanan/koel@65d403f857on
github.com/phanan/koel@a87b456f9beverything plays as it used to for me.@alex-phillips can you run
git checkout a87b456f9b140447c3c25f6a16f396a4d658e323and see if it works again.On master I have the issue in Firefox as well
@alex-phillips commented on GitHub (Aug 9, 2016):
@bdgold That checkout does work for me. I can play FLAC now.
Site note: is the email on your Github page good to contact you with the frontend information? (@bdgold)
@BernardGoldberger commented on GitHub (Aug 9, 2016):
Yes.
@BernardGoldberger commented on GitHub (Aug 10, 2016):
I have now the weirdest thing.
I was doing some tests with Koel and changed the
STREAMING_METHODtophp, after that I'm unable to get Opera to play any files, I believe I have tried everything. Firefox and Chrome are working.The error?
undefined:1 Uncaught (in promise) DOMException: Failed to load because no supported source was found.UPDATE
Opera just magically just began working again, I don't know why, but maybe it was cloudflare clearing some cache that I forgot to purge when I was done testing :-/
@phanan commented on GitHub (Aug 10, 2016):
Damn. Will check this out as soon as I can. Thanks for letting me know.
On Tuesday, August 9, 2016, bdgold notifications@github.com wrote:
@BernardGoldberger commented on GitHub (Aug 10, 2016):
@phanan does Koel check the
STREAMING_METHODon every play request? or does it store it somewhere?@phanan commented on GitHub (Aug 10, 2016):
@bdgold It checks for environment variables on every request, as it should.
@BernardGoldberger commented on GitHub (Aug 10, 2016):
Right.
So if I were to set it to some gibberish
STREAMING_METHOD=gibberishwhat should the expected behavior be?@phanan commented on GitHub (Aug 10, 2016):
@BernardGoldberger commented on GitHub (Aug 10, 2016):
Does
default:returnPHPStreamerfor anything that is not'x-sendfile':or'x-accel-redirect':? or unless its set to one of the 3 it should fail?@phanan commented on GitHub (Aug 10, 2016):
It's for anything that's not
x-sendfileorx-accel-redirect.