mirror of
https://github.com/koel/koel.git
synced 2026-04-26 09:15:59 +03:00
[GH-ISSUE #393] Bug: if condition for Last.fm & YouTube #283
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#283
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BernardGoldberger on GitHub (Aug 3, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/393
Windows, Master, Opera and Firefox.
Every 1 out of 5 or 6 times I load Koel it seems that the
if (YouTube::enabled()andif (Lastfm::used()are either returningfalseor are just simply not loading.I have no errors in the console or the log file, I'm not sure if this is a new bug as it might have been happening with Last.fm but I just didn't notice. I should point out that even when Last.fm says that its not integrated it will still get content info and display it but obviously that is not the case for YouTube.
I tried finding some kind of pattern but was unsuccessful, I tried a
try catchandlogbut got nothing.If there any tests I could to track this down, let me know.
@phanan commented on GitHub (Aug 7, 2016):
This is weird. I can't reproduce this.
@BernardGoldberger commented on GitHub (Aug 7, 2016):
Might be an issue specific to Windows.
@phanan commented on GitHub (Aug 8, 2016):
Thanks for the provided info. I confirm that this happens on your server, but still, I don't think this is a Koel bug per se. If you look at the code (I'm sure you did),
YouTube::enabled()simply callsreturn (bool) env('YOUTUBE_API_KEY');. Maybe this has something to do with how PHP is installed/configured on your server, or (less likely) a bug with Laravel or phpdotenv. Can you try running a simple phpdotenv include (not Koel-related) and see if the bug is there?@BernardGoldberger commented on GitHub (Aug 9, 2016):
I ran some tests outside of Koel and had no issues.
The only thing I did notice is that there is no issue when I have Koel running through Nginx. It seems that the combination of Koel and Apache Proxy'd through CloudFlare is what's causing the issue.
I guess there is no point in keeping this open as its very unlikely I will be able to drill down and figure out what it is.
@phanan commented on GitHub (Aug 10, 2016):
Sounds like a Cloudflare cache issue to me.
On Wednesday, August 10, 2016, bdgold notifications@github.com wrote:
@BernardGoldberger commented on GitHub (Aug 10, 2016):
I did turn off caching but still I would have issues, I do agree that it seems to be a cloudflare issue when I'm running Koel on Apache.
I did find this article and decided to go ahead and turn off
Rocket Loaderwith a page rule and it does seem like its not happening as often.When using cloudflare there are so many things in play that it becomes a real challenge to pin-point where an an issue is originating from.
Rocket Loaderseems to have been a contributing factor.Until others complain about this, I don't think we need worrying.
@akirakyle commented on GitHub (Aug 14, 2016):
Hi, I seem to be having an issue somewhat similar to this, however after upgrading I have yet to see the youtube tab appear. YouTube does seem to be receiving the API requests as it is reporting a new request everytime I play a song, also I have confirmed
YouTube::enabled()is returningtrue.I am running Apache on Arch linux, and have confirmed that this persists across firefox on both windows and mac, and chrome and safari on mac. I'm not really sure how to go about troubleshooting this as I don't really have any webdev experience.
@BernardGoldberger commented on GitHub (Aug 14, 2016):
After upgrading what? Koel or something else?
@akirakyle commented on GitHub (Aug 17, 2016):
After upgrading Koel from v3.1.1 to v3.2.0
@phanan commented on GitHub (Aug 17, 2016):
@akirakyle Have you tried
rm -rf node_modules && npm install?@akirakyle commented on GitHub (Aug 21, 2016):
I managed to fix it, I had previously run
rm -rf node_modules && npm installas per the upgrade guide, but I failed to notice the the warning npm gave:npm WARN lifecycle koel@~postinstall: cannot run in wd %s %s (wd=%s) koel@ cross-env NODE_ENV=production && gulp --production /usr/share/webapps/koelSo this time running
rm -rf node_modules && npm install --unsafe-permseems to have worked.@jujes commented on GitHub (Dec 6, 2016):
Hi, some possibility to expand youtube feature and save videos into playlists?
thanks in advance,