mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #40] How does Koel get album / artist covers? #28
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#28
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @askoxyz on GitHub (Dec 14, 2015).
Original GitHub issue: https://github.com/koel/koel/issues/40
So far it has managed to get no covers for any albums and/or artists I have, while they do show up in any other media player, so hence my question, how does Koel get the album covers, or how does it fetch them? from the song meta data or from a 3rd party (e.g last.fm or something)?
@askoxyz commented on GitHub (Dec 14, 2015):
Ok so I see it does all of this in Album.php#L68, but doesn't seem to actually work tough. Any thoughts?
@cgrossde commented on GitHub (Dec 14, 2015):
I also had some issues here: When importing Koel tries to put the images in
/img/covers, a folder that does not exist at the time. When accessing the covers it looks at/public/img/covers. The problem is, that this Laravel project is setup to have theindex.phpand.htaccessin/instead of/public. Therefore Laravel thinks thepublic_path()is/and not/public.Quick fix: Change link 72 in Album.php to
Clear the DB and reimport your music.
Better solution:
index.phpand.htaccessto/public@askoxyz commented on GitHub (Dec 14, 2015):
Yup. Went with the quick fix on this one and worked brilliantly. I do understand the use case for storing index and .htaccess in
/instead of/public, for example shared hosts which do not allow anything up frompublic_html, but then public_path() should also be changed accordingly from the get-go. Either way, thank you @cgrossde .@phanan commented on GitHub (Dec 14, 2015):
Thanks. Let's discuss in the PR.