mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #370] Bug: Compilation Album under Artists. #266
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#266
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BernardGoldberger on GitHub (Jul 8, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/370
Windows, Opera, Master.
compilation albums will now list all the songs under the same album, however I noticed 2 issues
I think that under Artists the Album should be found under Various Artists -> Albums, or under the Album Artist, Similar to https://github.com/phanan/koel/issues/21#issuecomment-211044496. Album Artist should group the entire Compilation under the same Album, see screenshot.
And of course thank you @phanan for the adding the support and I know that its still experimental but I figured I will report my findings.
@phanan commented on GitHub (Jul 9, 2016):
Hmm, that's weird. This is my screenshot of the same album as in https://github.com/phanan/koel/issues/21#issuecomment-211044496:
If possible, can you use a tag editor/scanner and show me your file's tags?
For 2. "Various Artists" is not meant to be searched. If 1. doesn't happen, the artist name shouldn't be "Various Artists" to be searchable to begin with.
@BernardGoldberger commented on GitHub (Jul 10, 2016):
I used Mp3tag
In regards to 2 I did try to search for the song artist and the album artist but It wouldn't show up.
Also right click and "Go to Artist" works and it takes me to "Verious Artists" with 10 Albums, but as I said not browsing through Artists
I checked the DB and found the following, the Album artist_id is 2
which is
but the Song contributing_artist_id is also 2
which seems to be the issue.
@phanan commented on GitHub (Jul 10, 2016):
Can you try backing up the database first and then running
php artisan koel:sync --tags=artist,compilation?@BernardGoldberger commented on GitHub (Jul 10, 2016):
Completed! 0 new or updated song(s), 8109 unchanged song(s), and 0 invalid file(s).I checked again and all is the same.
@phanan commented on GitHub (Jul 10, 2016):
That's weird. I guess they use different tags. If it's possible, can you send one of these files into my email me@phanan.net?
@BernardGoldberger commented on GitHub (Jul 10, 2016):
Sure, I should point out that this seems to be the case with all the compilations albums I have.
@phanan commented on GitHub (Jul 10, 2016):
Apparently I'm missing something here. Worth noting that I only have Mac &
iTunes to test around :P
On Sun, Jul 10, 2016 at 12:21 PM, bdgold notifications@github.com wrote:
@phanan commented on GitHub (Jul 10, 2016):
I think I know where the problem is. Will work on the fix real soon. Thanks for reporting @bdgold!
@phanan commented on GitHub (Jul 10, 2016):
Hm… actually no. This is the result on my end:
@BernardGoldberger commented on GitHub (Jul 10, 2016):
Hmmm, so I went now and removed the song from the scanned folder and did
php artisan koel:sync -vto remove the song and I verified that it doesnt show, the I added the song back and didphp artisan koel:sync -vand the song shows up the way it should, I then didphp artisan koel:sync -v --tags=artist,compilationjust to verify that it was not the issue and everything is good for that song@phanan commented on GitHub (Jul 10, 2016):
There must be some hiccups during upgrading then. The fault should be on my
part, but in all honesty, I can't guess what it is now :/
On Sun, Jul 10, 2016 at 1:16 PM, bdgold notifications@github.com wrote:
@BernardGoldberger commented on GitHub (Jul 11, 2016):
I just realized that when I ran
php artisan koel:sync --tags=artist,compilationit did not include--forceso I just ranphp artisan koel:sync -v --force --tags=artist,compilationand we are all goodIn the realease notes it should probably say to run
php artisan koel:sync --force --tags=artist,compilation@phanan commented on GitHub (Jul 11, 2016):
But it did:
On Mon, Jul 11, 2016 at 8:00 PM, bdgold notifications@github.com wrote:
@BernardGoldberger commented on GitHub (Jul 11, 2016):
In the release notes it says to run
php artisan koel:sync --force --tags=compilationyour suggestion to includeartist,is what did the trick.@phanan commented on GitHub (Jul 11, 2016):
Oh, right.
On Mon, Jul 11, 2016 at 10:17 PM, bdgold notifications@github.com wrote: