mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #319] Folder as a playlist would be a really nice feature #234
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#234
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sergiorodenas on GitHub (Apr 30, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/319
Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue:
All checked? Now also make sure your issue
@phanan commented on GitHub (May 1, 2016):
What do you mean by "folder as a playlist" exactly?
@ethus3h commented on GitHub (May 2, 2016):
maybe folders on the server side are synced with playlists? idk though...
@phanan commented on GitHub (May 2, 2016):
Then how about subfolders? I don't think that will work.
On Mon, May 2, 2016 at 8:59 AM, ethus3h notifications@github.com wrote:
@R0binvd commented on GitHub (May 3, 2016):
Maybe just a browse by folder menu?
@sergiorodenas commented on GitHub (May 3, 2016):
Just a folder menu, yeah, that's it.
I said "as a playlist" because the view could be really similar. Also, people as me use the folders as "playlist", we want to mix and listen just the music that is on the folder.
@sergiorodenas commented on GitHub (May 3, 2016):
Furthermore, songs metadata as album and artist usually are null, spam or wrong, so with folders the user will be able to edit them in a "bulk" way because they will be in the same folder. Then the artists, album and lastfm system will work as expected 😮 cause metadatas are okey
@phanan commented on GitHub (May 5, 2016):
This is not a bad idea, however its implementation would require more thinking and possibly a lot of code addition/changes, e.g. folder support, directory tree parsing and grouping etc. I'll leave this issue open to see if such a feature is in high demand though.
@sergiorodenas commented on GitHub (May 5, 2016):
Okey, I will try to do it by myself 🐤
@BernardGoldberger commented on GitHub (May 5, 2016):
@phanan @Rodenastyle I didn't understand in the start what the request was for but now that I do I have to say that it would be extremely useful and helpful, I had a similar thought a while ago but thought its too much too ask for.
+1
I'm looking forward to have this implemented.
@sergiorodenas commented on GitHub (May 5, 2016):
Unfortunately I'm not pretty sure I'm able to develop this cause the multiple languages used. I'm able to do things like folders tree and so on using PHP and Laravel, but not with JS and it's own world 😅
@sergiorodenas commented on GitHub (May 5, 2016):
But it is really really similar as Playlists model
@phanan commented on GitHub (May 5, 2016):
@bdgold There's no such thing as "too much to ask for" ;)
@sergiorodenas commented on GitHub (May 9, 2016):
@phanan Just to know, is this already on the roadmap or shall I start trying to do it?
@phanan commented on GitHub (May 10, 2016):
It's not on the roadmap, so please be my guest :)
On Tue, May 10, 2016 at 1:59 AM, Sergio Ródenas notifications@github.com
wrote:
@epheo commented on GitHub (May 17, 2016):
+1
Being able to use the folder hierarchy of your collection would be very helpful.
Even without considering the "playlist" aspect.
@My1 commented on GitHub (May 22, 2016):
I agree to folder hierarchy. I literally always use it for the same reason as a poerson above. ID3 data is more often that not junk, and look at it from a positive side. when making an option "folder only" or whatever it removes the need of having to scan and sync the MP3's ID3 tags in an overly large database. the ID3 tags can be shown while the file is played (where it's read anyway) and the relevant folders can de facto be walked live. that could remove a LOT of syncing.
@sergiorodenas commented on GitHub (May 22, 2016):
Definitely I have no enough time to develop this, but it's really needed. Really sorry.
@aroundmyroom commented on GitHub (Jun 5, 2016):
+1 here, as I have only 110.000 badly tagged songs (many wav, many flac) . mostly 12-inch ..
@x0gen commented on GitHub (Jun 6, 2016):
I agree with everyone else for the same reasons (several thousands songs with bad tags), would be really nice!
@epheo commented on GitHub (Jun 11, 2016):
@Rodenastyle
Hi guys,
I really needed that functionality, so spent my saturday on a crappy python script who take the folder name from the path, create playlists from that names and add all the songs from the directory in the playlist.
https://gist.github.com/epheo/fc63f0297d50b81103729817eaa6d5fe
Took a while to run, working fine.
(Like this it will not recreate an existant playlist but will readd the songs each time in the playlists.
If we check if the song_id already exist it will not be able to add a song in different playlists,
So we need to check the combination of both... wich isn't done)
@TwizzyDizzy commented on GitHub (Jun 22, 2016):
Hi folks,
I have read only the first posts, but I have writen a PHP script to create playlists from folders. Please read the remarks in the file - or if something is unclear after reading - ask:
https://github.com/TwizzyDizzy/scripts/tree/master/php/koel-playlists-from-folders
Cheers
Thomas
@X-Ryl669 commented on GitHub (Aug 10, 2016):
@phanan: Whatabout the following process (if ok, I might give it a try):
From a php point of view, I need to modify the data controller to also return a "folder" key with all recursive children. I'm not sure if it's the right way, or if I need to add a new route to get the folder list (I don't think it's useful to fetch the list until it's being used, as it will take a lot of (duplicate) memory with the songs's array already)
@X-Ryl669 commented on GitHub (Sep 1, 2016):
Ok, I've done it and it works well. Please find it here: https://github.com/X-Ryl669/koel
I'm not submitting PR here since my solution depends on previous PR @phanan rejected.
@bhajneet commented on GitHub (Sep 28, 2016):
Just wanted to input one more person's demand for this issue. This is how all my music is organized and I always play in terms of folder hierarchy.
I usually either just play A for all of SA-1 and SA-2 combine or I can choose a subfolder inside it to play. This is the reason I can't leave foobar for my native application actually. It's amazing how such an old music player has had this feature and new music players often want you to re-create your playlists or import them from somewhere else. When the easiest way to make a playlist is to move songs around. (Of course you can't duplicate the same song in playlists without wasting more harddrive space or messing around with hard links, so I understand the benefits of evolving to playlists as well).
@X-Ryl669 commented on GitHub (Sep 29, 2016):
This is exactly what my fork does. Have a look ;-)
@julianxhokaxhiu commented on GitHub (Apr 9, 2017):
Is this feature merged in the main koel app? I'm really looking for a web player that uses the Folder logic, and I was willing to create mine in NodeJS, although I've found your fork @X-Ryl669 which is amazing.
My only concern lives in the fact I would need to live with your fork forever, unless you keep in sync with @phanan work. Why not join forces and make the feature live in one repo only?
@X-Ryl669 commented on GitHub (Apr 10, 2017):
@phanan is doing amazing work to keep this app perfect (the code quality is very high).
I'm trying to fit his coding expectation, but I'm probably more pragmatic, so I've spent my time in implementing the features I was expecting from the application. When the change I'm doing are small and atomic, I'm creating a pull request and, usually, @phanan merges it. The folder code however was rejected because, IIRC, it was not the direction @phanan wanted the application to go and maybe because the code quality was not good enough at the time (which has probably improved, since I've learned a lot from @phanan coding practices).
In my fork, I've added many experimental features you might not want (like Genre browsing, Web-based library scanning with feedback, integration within a CMS...)
Right now, I'm doing a real native application for Android that would allow to browse your music library offline (with synchronization when you're online) and the plugin for the open-source Orpheus music player. It's not currently working smoothly, but it's coming soon when I think it'll be ready for testing. Once this is done, I'll have more time to split my work in smaller pieces and ask them to be integrated again.
@UmutAlihan commented on GitHub (Oct 9, 2020):
Please please please merge this feature with master :)
I sincerely would think that the only step this app is away from perfection is missing this feature. Just please :)
@artebin commented on GitHub (Nov 29, 2020):
Same thing for me, the folder view really is a user need :)
@PotatoYummy commented on GitHub (Jul 18, 2021):
+1
@MetallicAchu commented on GitHub (Jul 29, 2021):
+1
@poisonborz commented on GitHub (Feb 3, 2022):
https://dev.funkwhale.audio/funkwhale/funkwhale/-/issues/1397
Funkwhale did also recently budge on this... Folder view would be super useful, and it's hard to believe it's ignored by most major selfhosted media servers. Lots of users already have their files organized... in a file system. No tagging or playlists needed. They just want access to that ready-made hierarchy.
@tidux commented on GitHub (Mar 12, 2022):
https://mstream.io/ might be what you're looking for @poisonborz
@poisonborz commented on GitHub (Mar 12, 2022):
Oooh that really does look great! Thanks, @tidux!