starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-25 00:36:03 +03:00

[GH-ISSUE #314] Play album should add to queue in track number order #230

New issue

Closed

opened 2026-02-26 02:32:30 +03:00 by kerem · 7 comments

kerem commented

2026-02-26 02:32:30 +03:00

Owner

Originally created by @MitchLillie on GitHub (Apr 22, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/314

Steps to reproduce:

Click 'Albums' from menu at left
Search for an album or artist
Click the play icon on the album art
The songs get added to the queue, but are shuffled.

Desired behavior:

Songs are added to the queue in album track number order

Looks like the issue is twofold:

Initially, no false for shuffle is being passed to playback.playAllInAlbum on line 41 of album-item.vue
Then, on line 390 of playback.js—the shuffle param isn't getting passed to the queueAndPlay method.

Happy to make a quick PR if this looks good. :) If you want a commit hash for this one it's probably, well, 0ee3728.

Originally created by @MitchLillie on GitHub (Apr 22, 2016). Original GitHub issue: https://github.com/koel/koel/issues/314 Steps to reproduce: 1. Click 'Albums' from menu at left 2. Search for an album or artist 3. Click the play icon on the album art 4. The songs get added to the queue, but are shuffled. Desired behavior: - Songs are added to the queue in album track number order Looks like the issue is twofold: - Initially, no `false` for shuffle is being passed to `playback.playAllInAlbum` on [line 41 of album-item.vue](https://github.com/phanan/koel/blob/ec6cd1bb08b409b29321b8d4538aec1adc90c6de/resources/assets/js/components/shared/album-item.vue#L41) - Then, on [line 390 of playback.js](https://github.com/phanan/koel/blob/1efe92f7b8157df99b5aff301dfa4e9d9260bc6a/resources/assets/js/services/playback.js#L390)—the `shuffle` param isn't getting passed to the `queueAndPlay` method. Happy to make a quick PR if this looks good. :) If you want a commit hash for this one it's probably, well, 0ee3728.

kerem

2026-02-26 02:32:30 +03:00

closed this issue
added the
[Status] Will Implement
label

kerem commented

2026-02-26 02:32:31 +03:00

Author

Owner

@BernardGoldberger commented on GitHub (Apr 22, 2016):

I completely agree with @MitchLillie , I have also suggested in the past about adding an additional shuffle button https://github.com/phanan/koel/issues/137.

I believe there were also others that requested it.

@BernardGoldberger commented on GitHub (Apr 22, 2016): I completely agree with @MitchLillie , I have also suggested in the past about adding an additional shuffle button https://github.com/phanan/koel/issues/137. I believe there were also others that requested it.

kerem commented

2026-02-26 02:32:31 +03:00

Author

Owner

@phanan commented on GitHub (Apr 23, 2016):

I haven't forgotten about this. Still thinking about the GUI though, i.e. how "Shuffle" and "Play in Order" buttons can live beautifully together, both on desktop and mobile. If you guys have an idea, please let me know.

@phanan commented on GitHub (Apr 23, 2016): I haven't forgotten about this. Still thinking about the GUI though, i.e. how "Shuffle" and "Play in Order" buttons can live beautifully together, both on desktop and mobile. If you guys have an idea, please let me know.

kerem commented

2026-02-26 02:32:31 +03:00

Author

Owner

@BernardGoldberger commented on GitHub (Apr 25, 2016):

live beautifully together

Maybe they shouldn't, how about there should be a global setting under the users profile where they can select what their preference is?

I'm still thinking on what a nice a comfy design there might be for them living together but it seems like it would take some thinking out of the box.

@BernardGoldberger commented on GitHub (Apr 25, 2016): > live beautifully together Maybe they shouldn't, how about there should be a global setting under the users profile where they can select what their preference is? I'm still thinking on what a nice a comfy design there might be for them living together but it seems like it would take some thinking out of the box.

kerem commented

2026-02-26 02:32:31 +03:00

Author

Owner

@phanan commented on GitHub (Apr 25, 2016):

IMO such behavior doesn't need/isn't applicable to be a preference, and I'm not a fan of cluttering preferences anyway. Will be thinking about this.

@phanan commented on GitHub (Apr 25, 2016): IMO such behavior doesn't need/isn't applicable to be a preference, and I'm not a fan of cluttering preferences anyway. Will be thinking about this.

kerem commented

2026-02-26 02:32:31 +03:00

Author

Owner

@MitchLillie commented on GitHub (Apr 25, 2016):

I agree with both of you—no need to clutter preferences or the GUI. The "default" behavior, especially for an album (in the search view as described above), should probably be to add to the queue in order. However, if you click through to the list of songs, there could be an option at the top to add all songs to the queue shuffled, while if you just double click the first song, the entire album is queued in order. My 2¢ :)

@MitchLillie commented on GitHub (Apr 25, 2016): I agree with both of you—no need to clutter preferences or the GUI. The "default" behavior, especially for an album (in the search view as described above), should probably be to add to the queue in order. However, if you click through to the list of songs, there could be an option at the top to add all songs to the queue shuffled, while if you just double click the first song, the entire album is queued in order. My 2¢ :)

kerem commented

2026-02-26 02:32:31 +03:00

Author

Owner

@Mechazawa commented on GitHub (Apr 25, 2016):

Why not just make it so that it just adds them? Since there is already a shuffle button in the playlist view.

@Mechazawa commented on GitHub (Apr 25, 2016): Why not just make it so that it just adds them? Since there is already a shuffle button in the playlist view.

kerem commented

2026-02-26 02:32:31 +03:00

Author

Owner

@BernardGoldberger commented on GitHub (Apr 26, 2016):

Here are a few ideas...

Create a shuffle button similar to the repeat button and in that case if its selected the songs are always shuffled [similar to iOS music app].
Little bit more complex, in the list view we can have 2 "Play" buttons on the right side and on the left side one for shuffling and one for playing, on a mobile device this can be implemented with a swipe gesture by either swiping to the right or the left, i don't believe this would work well for the tiled view unless we go back to having the width of the tile take up the entire width of the screen.

@BernardGoldberger commented on GitHub (Apr 26, 2016): Here are a few ideas... 1. Create a shuffle button similar to the repeat button and in that case if its selected the songs are always shuffled [similar to iOS music app]. 2. Little bit more complex, in the list view we can have 2 "Play" buttons on the right side and on the left side one for shuffling and one for playing, on a mobile device this can be implemented with a swipe gesture by either swiping to the right or the left, i don't believe this would work well for the tiled view unless we go back to having the width of the tile take up the entire width of the screen.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#230

No description provided.

Rows
Columns