starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-26 09:15:59 +03:00

[GH-ISSUE #305] Clear search query when user toggles off the search box on mobile #223

New issue

Closed

opened 2026-02-26 02:32:30 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 02:32:30 +03:00

Owner

Originally created by @phanan on GitHub (Apr 17, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/305

Originally assigned to: @phanan on GitHub.

Problem

On a mobile device, the search box is designed to be hidden most of the time. As the song lists are filtered by the search query, this behavior may lead to the wrong idea of how many songs the current song list contains. Visual example:

User seaches for a song. The song list is filtered to show only matching results:

He clicks the search icon to hide the search form. As the search query is still kept albeit hidden, the list remains at the same state.

This can be quite misleading, as the user can now at first glance be tricked into thinking that "All Songs" has only one item, or lost at how to find the rest.

Solution:

On mobile, clear the search query when the user hides the search box.

Originally created by @phanan on GitHub (Apr 17, 2016). Original GitHub issue: https://github.com/koel/koel/issues/305 Originally assigned to: @phanan on GitHub. #### Problem On a mobile device, the search box is designed to be hidden most of the time. As the song lists are filtered by the search query, this behavior may lead to the wrong idea of how many songs the current song list contains. Visual example: User seaches for a song. The song list is filtered to show only matching results: ![image](https://cloud.githubusercontent.com/assets/8056274/14585119/ff8249c6-049a-11e6-98ea-11a017d06cb3.png) He clicks the search icon to hide the search form. As the search query is still kept albeit hidden, the list remains at the same state. ![image](https://cloud.githubusercontent.com/assets/8056274/14585123/41426c24-049b-11e6-8ec1-7b3c3016358e.png) This can be quite misleading, as the user can now at first glance be tricked into thinking that "All Songs" has only one item, or lost at how to find the rest. #### Solution: On mobile, clear the search query when the user hides the search box.

kerem closed this issue

2026-02-26 02:32:30 +03:00

kerem commented

2026-02-26 02:32:30 +03:00

Author

Owner

@BernardGoldberger commented on GitHub (Sep 6, 2016):

Ping @phanan

@BernardGoldberger commented on GitHub (Sep 6, 2016): Ping @phanan

kerem commented

2026-02-26 02:32:30 +03:00

Author

Owner

@phanan commented on GitHub (Sep 25, 2016):

After some consideration, I've come to believe this should be left in user's land, i.e. Koel shouldn't try to act smart. If the user's confused, it's their mistake.

@phanan commented on GitHub (Sep 25, 2016): After some consideration, I've come to believe this should be left in user's land, i.e. Koel shouldn't try to act smart. If the user's confused, it's their mistake.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#223

No description provided.

Rows
Columns