[PR #2179] [CLOSED] fix: reactivity issue in edit smart playlist modal #2127

New issue

Closed

opened 2026-02-26 03:33:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:33:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2179
Author: @ngiamour
Created: 12/18/2025
Status: ❌ Closed

Base: master ← Head: fix/smart-playlist-reactivity

📝 Commits (3)

b818f3f fix: reactivity issue in edit smart playlist modal
306795a Update resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue
d26ebdd Update resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue

📊 Changes

1 file changed (+16 additions, -4 deletions)

View changed files

📝 resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue (+16 -4)

📄 Description

Summary

This PR fixes a reactivity issue where adding a new group in the "Edit Smart Playlist" modal wouldn't update the UI immediately.

Technical Details

The template was iterating over mutablePlaylist.rules (static copy) instead of collectedRuleGroups (reactive source). This caused a desync between the data state and the visual state.

Changes

Updated v-for loop to use collectedRuleGroups.
Removed unused mutablePlaylist variable to satisfy linter.

Fixes

Fixes #2172

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2179 **Author:** [@ngiamour](https://github.com/ngiamour) **Created:** 12/18/2025 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fix/smart-playlist-reactivity` --- ### 📝 Commits (3) - [`b818f3f`](https://github.com/koel/koel/commit/b818f3f5dc9a28b4b0b252bdabb97894747ae89d) fix: reactivity issue in edit smart playlist modal - [`306795a`](https://github.com/koel/koel/commit/306795a5905f11db656e668883dbf7c6055e115d) Update resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue - [`d26ebdd`](https://github.com/koel/koel/commit/d26ebdd1f5fdcbcf0dc30a45651e51e84b935c69) Update resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue ### 📊 Changes **1 file changed** (+16 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue` (+16 -4) </details> ### 📄 Description ### Summary This PR fixes a reactivity issue where adding a new group in the "Edit Smart Playlist" modal wouldn't update the UI immediately. ### Technical Details The template was iterating over `mutablePlaylist.rules` (static copy) instead of `collectedRuleGroups` (reactive source). This caused a desync between the data state and the visual state. ### Changes * Updated `v-for` loop to use `collectedRuleGroups`. * Removed unused `mutablePlaylist` variable to satisfy linter. ### Fixes Fixes #2172 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:33:21 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#2127

No description provided.

Rows
Columns