[PR #2178] [MERGED] Fix missing lyrics support for FLAC files #2122

New issue

Closed

opened 2026-02-26 03:33:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:33:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2178
Author: @ngiamour
Created: 12/15/2025
Status: ✅ Merged
Merged: 12/15/2025
Merged by: @phanan

Base: master ← Head: fix/flac-lyrics-support

📝 Commits (1)

63d1965 Fix: Add support for Vorbis comments and LYRICS tag in FLAC files

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 app/Values/Scanning/ScanInformation.php (+2 -0)

📄 Description

Summary

This PR fixes an issue where lyrics embedded in FLAC files were not being detected by the scanner.

Technical Details

The scanner was primarily targeting ID3 tags (used in MP3s), but FLAC files use Vorbis Comments for metadata.

The tags.vorbiscomment array returned by getID3 was previously excluded during the tag merge process.
The standard Vorbis comment key for lyrics is simply LYRICS, which was missing from the lookup list (unlike ID3's unsynchronised_lyric).

Changes

Modified ScanInformation.php:
- Included tags.vorbiscomment in the array_merge logic to expose native FLAC tags.
- Added 'lyrics' to the priority list when extracting lyric data.

Fixes

Fixes #2176

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2178 **Author:** [@ngiamour](https://github.com/ngiamour) **Created:** 12/15/2025 **Status:** ✅ Merged **Merged:** 12/15/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix/flac-lyrics-support` --- ### 📝 Commits (1) - [`63d1965`](https://github.com/koel/koel/commit/63d1965ebb019a63fe0b1136b65270fddaae974c) Fix: Add support for Vorbis comments and LYRICS tag in FLAC files ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/Values/Scanning/ScanInformation.php` (+2 -0) </details> ### 📄 Description ### Summary This PR fixes an issue where lyrics embedded in FLAC files were not being detected by the scanner. ### Technical Details The scanner was primarily targeting ID3 tags (used in MP3s), but FLAC files use Vorbis Comments for metadata. 1. The `tags.vorbiscomment` array returned by `getID3` was previously excluded during the tag merge process. 2. The standard Vorbis comment key for lyrics is simply `LYRICS`, which was missing from the lookup list (unlike ID3's `unsynchronised_lyric`). ### Changes * **Modified `ScanInformation.php`**: * Included `tags.vorbiscomment` in the `array_merge` logic to expose native FLAC tags. * Added `'lyrics'` to the priority list when extracting lyric data. ### Fixes Fixes #2176 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:33:20 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#2122

No description provided.

Rows
Columns