[PR #2173] [MERGED] fix: slow scan (closes #2165) #2120

Closed
opened 2026-02-26 03:33:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2173
Author: @phanan
Created: 12/6/2025
Status: Merged
Merged: 12/6/2025
Merged by: @phanan

Base: masterHead: fix-2165


📝 Commits (1)

📊 Changes

6 files changed (+31 additions, -26 deletions)

View changed files

📝 app/Helpers.php (+3 -3)
📝 app/Models/Song.php (+2 -8)
📝 app/Services/Scanners/Scanner.php (+11 -7)
📝 app/Services/SongService.php (+7 -5)
📝 docs/troubleshooting.md (+5 -0)
📝 tests/Integration/Services/Scanners/DirectoryScannerTest.php (+3 -3)

📄 Description

Description

Fix the issue with slow scanning due to Koel relying on file hashes instead of mtime.

Motivation

Screenshots (if applicable)

Checklist

  • I've tested my changes thoroughly and added tests where applicable
  • I've updated relevant documentation (if any)
  • My code follows the project's conventions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2173 **Author:** [@phanan](https://github.com/phanan) **Created:** 12/6/2025 **Status:** ✅ Merged **Merged:** 12/6/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix-2165` --- ### 📝 Commits (1) - [`660ea57`](https://github.com/koel/koel/commit/660ea578d6c3f072507a8f75c3dbd86acc96af83) fix: slow scan (closes #2165) ### 📊 Changes **6 files changed** (+31 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `app/Helpers.php` (+3 -3) 📝 `app/Models/Song.php` (+2 -8) 📝 `app/Services/Scanners/Scanner.php` (+11 -7) 📝 `app/Services/SongService.php` (+7 -5) 📝 `docs/troubleshooting.md` (+5 -0) 📝 `tests/Integration/Services/Scanners/DirectoryScannerTest.php` (+3 -3) </details> ### 📄 Description <!-- Thank you for contributing to Koel! Please provide a clear description of your changes below. --> ## Description Fix the issue with slow scanning due to Koel relying on file hashes instead of mtime. ## Motivation <!-- Explain why this change is necessary, e.g., if targeting an existing issue, link to it. --> ## Screenshots (if applicable) ## Checklist - [x] I've tested my changes thoroughly and added tests where applicable - [x] I've updated relevant documentation (if any) - [x] My code follows the project's conventions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:33:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#2120
No description provided.