[PR #2152] [MERGED] feat(ui): use dialog element for context menus #2112

Closed
opened 2026-02-26 03:33:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2152
Author: @phanan
Created: 10/24/2025
Status: Merged
Merged: 10/24/2025
Merged by: @phanan

Base: masterHead: context-menu-dialog


📝 Commits (1)

  • 812f7cd feat(ui): use dialog element for context menus

📊 Changes

1 file changed (+13 additions, -13 deletions)

View changed files

📝 resources/assets/js/components/ui/context-menu/ContextMenu.vue (+13 -13)

📄 Description

Description

Use the <dialog> element for context menus, ensuring it always appears on top of other layers (and even other top-layer elements).

Motivation

Screenshots (if applicable)

Checklist

  • I've tested my changes thoroughly and added tests where applicable
  • I've updated relevant documentation (if any)
  • My code follows the project's conventions

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2152 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `context-menu-dialog` --- ### 📝 Commits (1) - [`812f7cd`](https://github.com/koel/koel/commit/812f7cd2819cb1a0bb5e9f47cf00cfcac01e03b4) feat(ui): use dialog element for context menus ### 📊 Changes **1 file changed** (+13 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/ui/context-menu/ContextMenu.vue` (+13 -13) </details> ### 📄 Description <!-- Thank you for contributing to Koel! Please provide a clear description of your changes below. --> ## Description Use the `<dialog>` element for context menus, ensuring it always appears on top of other layers (and even other top-layer elements). ## Motivation <!-- Explain why this change is necessary, e.g., if targeting an existing issue, link to it. --> ## Screenshots (if applicable) ## Checklist - [x] I've tested my changes thoroughly and added tests where applicable - [x] I've updated relevant documentation (if any) - [x] My code follows the project's conventions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:33:18 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#2112
No description provided.