[PR #2149] [MERGED] fix: enable picking custom themes when creating embeds #2109

New issue

Closed

opened 2026-02-26 03:33:18 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:33:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2149
Author: @phanan
Created: 10/24/2025
Status: ✅ Merged
Merged: 10/24/2025
Merged by: @phanan

Base: master ← Head: embed-themes

📝 Commits (1)

636c991 fix: enable picking custom themes when creating embeds

📊 Changes

13 files changed (+166 additions, -21 deletions)

View changed files

📝 app/Http/Controllers/API/Embed/EmbedController.php (+10 -1)
📝 app/Http/Controllers/API/FetchInitialDataController.php (+5 -3)
📝 composer.json (+2 -1)
📝 resources/assets/js/components/embed/CreateEmbedForm.spec.ts (+7 -1)
➕ resources/assets/js/components/embed/EmbedOptionsPanel.spec.ts (+37 -0)
📝 resources/assets/js/components/embed/EmbedOptionsPanel.vue (+5 -11)
➕ resources/assets/js/components/embed/ThemeSelectBox.spec.ts (+28 -0)
➕ resources/assets/js/components/embed/ThemeSelectBox.vue (+25 -0)
📝 resources/assets/js/components/embed/widget/EmbedWidget.vue (+2 -1)
📝 resources/assets/js/components/embed/widget/audio-player/EmbedAudioPlayerPlayButton.vue (+2 -2)
📝 resources/assets/js/stores/embedService.ts (+1 -1)
📝 tests/Feature/EmbedTest.php (+1 -0)
➕ tests/Feature/KoelPlus/EmbedTest.php (+41 -0)

📄 Description

Description

Add custom themes to the theme selection when creating embeds.

Motivation

Screenshots (if applicable)

Checklist

I've tested my changes thoroughly and added tests where applicable
I've updated relevant documentation (if any)
My code follows the project's conventions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2149 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/24/2025 **Status:** ✅ Merged **Merged:** 10/24/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `embed-themes` --- ### 📝 Commits (1) - [`636c991`](https://github.com/koel/koel/commit/636c99126bdc5f067c0ebbe5084be9ecb14f4d33) fix: enable picking custom themes when creating embeds ### 📊 Changes **13 files changed** (+166 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/API/Embed/EmbedController.php` (+10 -1) 📝 `app/Http/Controllers/API/FetchInitialDataController.php` (+5 -3) 📝 `composer.json` (+2 -1) 📝 `resources/assets/js/components/embed/CreateEmbedForm.spec.ts` (+7 -1) ➕ `resources/assets/js/components/embed/EmbedOptionsPanel.spec.ts` (+37 -0) 📝 `resources/assets/js/components/embed/EmbedOptionsPanel.vue` (+5 -11) ➕ `resources/assets/js/components/embed/ThemeSelectBox.spec.ts` (+28 -0) ➕ `resources/assets/js/components/embed/ThemeSelectBox.vue` (+25 -0) 📝 `resources/assets/js/components/embed/widget/EmbedWidget.vue` (+2 -1) 📝 `resources/assets/js/components/embed/widget/audio-player/EmbedAudioPlayerPlayButton.vue` (+2 -2) 📝 `resources/assets/js/stores/embedService.ts` (+1 -1) 📝 `tests/Feature/EmbedTest.php` (+1 -0) ➕ `tests/Feature/KoelPlus/EmbedTest.php` (+41 -0) </details> ### 📄 Description  ## Description Add custom themes to the theme selection when creating embeds. ## Motivation  ## Screenshots (if applicable) ## Checklist - [x] I've tested my changes thoroughly and added tests where applicable - [x] I've updated relevant documentation (if any) - [x] My code follows the project's conventions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:33:18 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#2109

No description provided.

Rows
Columns