mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #290] virtual list for song views #210
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#210
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Spunge on GitHub (Mar 30, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/290
Hey Phanan,
One of the issues with Koel i'm having so far is that the song list is not easily scrollable. This hinders me from easily discovering random artists that i haven't listened to in a while.
After some searching for a possible solution i stumbled upon virtual lists, a react implementation can be seen here: http://developerdizzle.github.io/react-virtual-list/
Is there some way we could use something like this to make the song lists easily scrollable?
@phanan commented on GitHub (Mar 31, 2016):
This is a nice idea, though I'm not very sure if such a concept (virtual list) is applicable for our case, as the song lists in Koel can be filtered and sorted as well, thus are more dynamic in terms of both content and item length. Will explore more.
@Spunge commented on GitHub (Mar 31, 2016):
Thanks, i'm very interested in hearing your thoughts on this.
@BernardGoldberger commented on GitHub (Mar 31, 2016):
Maybe something like this would work
This should be implemented for "Artists" and "Album" and the jumpTo should be based on sortBy selected by the user.
On Mobile devices it should be a drop-down box.
@Spunge commented on GitHub (Apr 7, 2016):
That would probably work great on mobile, but not solve my issue.
I would really much just like the "all songs" view be scrollable, without it interrupting when loading new results.
Virtual lists seem to solve exactly this problem,
@phanan commented on GitHub (Apr 8, 2016):
Virtual list is a great idea. However, there are at least two factors that
I'd need to cater for: filter and selection. These features will need to be
modified or rewritten completely, if possible at all (especially selection).
On Fri, Apr 8, 2016 at 5:40 AM, Johan Schuijt notifications@github.com
wrote:
@Spunge commented on GitHub (Apr 21, 2016):
I see, a nice example of an implementation is: https://clusterize.js.org/
They have an example concerning filtering: http://codepen.io/NeXTs/pen/zvBveE
Would this be usable in our case?
Selection seems to be harder indeed, i'm still searching for a good example.
I will post an example here as soon as i find one.
@phanan commented on GitHub (Apr 21, 2016):
Selection can actually be managed by an array of selected row's ID, so it's
not that hard. Just that I'm kind of busy nowadays…
On Thu, Apr 21, 2016 at 7:17 PM, Johan Schuijt notifications@github.com
wrote:
@Spunge commented on GitHub (Apr 21, 2016):
I've edited the example from clusterize, would something like this work?
http://codepen.io/anon/pen/QNBWxN
I will try to free up some time, i'm in the same boat though.
@phanan commented on GitHub (Apr 21, 2016):
Sure, it works beautifully!
On Thu, Apr 21, 2016 at 9:25 PM, Johan Schuijt notifications@github.com
wrote:
@phanan commented on GitHub (Jan 14, 2017):
Implemented on
masterbranch, and should be available in next release.@Spunge commented on GitHub (Jan 17, 2017):
@phanan Very nice, thanks!
@smcvb commented on GitHub (Jan 17, 2017):
Awesome, looking forward to this!
@phanan commented on GitHub (Jan 17, 2017):
Actually it's already out :)
@smcvb commented on GitHub (Jan 17, 2017):
Works like a charm!