[PR #2126] [MERGED] feat: use v-bind instead of injection for modal context #2091

New issue

Closed

opened 2026-02-26 03:33:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:33:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2126
Author: @phanan
Created: 10/7/2025
Status: ✅ Merged
Merged: 10/7/2025
Merged by: @phanan

Base: master ← Head: revamp-modal

📝 Commits (1)

75d9926 feat: use v-bind instead of injection for modal context

📊 Changes

25 files changed (+79 additions, -130 deletions)

View changed files

📝 resources/assets/js/components/album/EditAlbumForm.spec.ts (+2 -6)
📝 resources/assets/js/components/album/EditAlbumForm.vue (+3 -3)
📝 resources/assets/js/components/artist/EditArtistForm.spec.ts (+2 -6)
📝 resources/assets/js/components/artist/EditArtistForm.vue (+3 -3)
📝 resources/assets/js/components/embed/CreateEmbedForm.spec.ts (+2 -6)
📝 resources/assets/js/components/embed/CreateEmbedForm.vue (+3 -4)
📝 resources/assets/js/components/layout/ModalWrapper.vue (+5 -7)
📝 resources/assets/js/components/playable/EditSongForm.spec.ts (+7 -13)
📝 resources/assets/js/components/playable/EditSongForm.vue (+7 -5)
📝 resources/assets/js/components/playlist/CreatePlaylistForm.spec.ts (+3 -6)
📝 resources/assets/js/components/playlist/CreatePlaylistForm.vue (+6 -4)
📝 resources/assets/js/components/playlist/EditPlaylistFolderForm.spec.ts (+2 -6)
📝 resources/assets/js/components/playlist/EditPlaylistFolderForm.vue (+3 -3)
📝 resources/assets/js/components/playlist/EditPlaylistForm.spec.ts (+2 -6)
📝 resources/assets/js/components/playlist/EditPlaylistForm.vue (+3 -2)
📝 resources/assets/js/components/playlist/PlaylistCollaborationModal.spec.ts (+3 -5)
📝 resources/assets/js/components/playlist/PlaylistCollaborationModal.vue (+3 -2)
📝 resources/assets/js/components/playlist/smart-playlist/CreateSmartPlaylistForm.vue (+3 -2)
📝 resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue (+4 -2)
📝 resources/assets/js/components/radio/EditRadioStationForm.spec.ts (+3 -6)

...and 5 more files

📄 Description

Description

Use v-bind instead of provide/inject for modal context.

Motivation

Screenshots (if applicable)

Checklist

I've tested my changes thoroughly and added tests where applicable
I've updated relevant documentation (if any)
My code follows the project's conventions

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2126 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/7/2025 **Status:** ✅ Merged **Merged:** 10/7/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `revamp-modal` --- ### 📝 Commits (1) - [`75d9926`](https://github.com/koel/koel/commit/75d99263c0d375e8cdcab378ad1368c5e2b92570) feat: use v-bind instead of injection for modal context ### 📊 Changes **25 files changed** (+79 additions, -130 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/album/EditAlbumForm.spec.ts` (+2 -6) 📝 `resources/assets/js/components/album/EditAlbumForm.vue` (+3 -3) 📝 `resources/assets/js/components/artist/EditArtistForm.spec.ts` (+2 -6) 📝 `resources/assets/js/components/artist/EditArtistForm.vue` (+3 -3) 📝 `resources/assets/js/components/embed/CreateEmbedForm.spec.ts` (+2 -6) 📝 `resources/assets/js/components/embed/CreateEmbedForm.vue` (+3 -4) 📝 `resources/assets/js/components/layout/ModalWrapper.vue` (+5 -7) 📝 `resources/assets/js/components/playable/EditSongForm.spec.ts` (+7 -13) 📝 `resources/assets/js/components/playable/EditSongForm.vue` (+7 -5) 📝 `resources/assets/js/components/playlist/CreatePlaylistForm.spec.ts` (+3 -6) 📝 `resources/assets/js/components/playlist/CreatePlaylistForm.vue` (+6 -4) 📝 `resources/assets/js/components/playlist/EditPlaylistFolderForm.spec.ts` (+2 -6) 📝 `resources/assets/js/components/playlist/EditPlaylistFolderForm.vue` (+3 -3) 📝 `resources/assets/js/components/playlist/EditPlaylistForm.spec.ts` (+2 -6) 📝 `resources/assets/js/components/playlist/EditPlaylistForm.vue` (+3 -2) 📝 `resources/assets/js/components/playlist/PlaylistCollaborationModal.spec.ts` (+3 -5) 📝 `resources/assets/js/components/playlist/PlaylistCollaborationModal.vue` (+3 -2) 📝 `resources/assets/js/components/playlist/smart-playlist/CreateSmartPlaylistForm.vue` (+3 -2) 📝 `resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue` (+4 -2) 📝 `resources/assets/js/components/radio/EditRadioStationForm.spec.ts` (+3 -6) _...and 5 more files_ </details> ### 📄 Description  ## Description Use `v-bind` instead of provide/inject for modal context. ## Motivation  ## Screenshots (if applicable) ## Checklist - [x] I've tested my changes thoroughly and added tests where applicable - [x] I've updated relevant documentation (if any) - [x] My code follows the project's conventions --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:33:15 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#2091

No description provided.

Rows
Columns