[PR #2107] [MERGED] fix: proper error handle and other improvements for embeds #2074

New issue

Closed

opened 2026-02-26 03:33:12 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:33:12 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2107
Author: @phanan
Created: 9/18/2025
Status: ✅ Merged
Merged: 9/18/2025
Merged by: @phanan

Base: master ← Head: embed-404

📝 Commits (1)

b798ba3 fix: proper error handle and other improvements for embeds

📊 Changes

23 files changed (+496 additions, -123 deletions)

View changed files

➕ app/Exceptions/EmbeddableNotFoundException.php (+9 -0)
📝 app/Http/Controllers/API/Embed/EmbedController.php (+10 -4)
📝 app/Repositories/SongRepository.php (+3 -0)
📝 resources/assets/js/components/embed/CreateEmbedForm.vue (+1 -1)
📝 resources/assets/js/components/embed/EmbedOptionsPanel.vue (+0 -0)
➕ resources/assets/js/components/embed/widget/EmbedWidget.spec.ts (+93 -0)
📝 resources/assets/js/components/embed/widget/EmbedWidget.vue (+19 -111)
➕ resources/assets/js/components/embed/widget/EmbedWidgetBanner.spec.ts (+168 -0)
➕ resources/assets/js/components/embed/widget/EmbedWidgetBanner.vue (+65 -0)
➕ resources/assets/js/components/embed/widget/EmbedWidgetErrorMessage.vue (+8 -0)
📝 resources/assets/js/components/embed/widget/EmbedWidgetThumbnail.spec.ts (+2 -2)
📝 resources/assets/js/components/embed/widget/EmbedWidgetThumbnail.vue (+0 -0)
📝 resources/assets/js/components/embed/widget/EmbedWidgetTrackItem.spec.ts (+2 -2)
📝 resources/assets/js/components/embed/widget/EmbedWidgetTrackItem.vue (+0 -0)
➕ resources/assets/js/components/embed/widget/EmbedWidgetTrackList.spec.ts (+23 -0)
➕ resources/assets/js/components/embed/widget/EmbedWidgetTrackList.vue (+40 -0)
➕ resources/assets/js/components/embed/widget/PreviewBadge.spec.ts (+12 -0)
➕ resources/assets/js/components/embed/widget/PreviewBadge.vue (+10 -0)
➕ resources/assets/js/components/embed/widget/__snapshots__/EmbedWidgetTrackItem.spec.ts.snap (+13 -0)
➕ resources/assets/js/components/embed/widget/__snapshots__/PreviewBadge.spec.ts.snap (+3 -0)

...and 3 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2107 **Author:** [@phanan](https://github.com/phanan) **Created:** 9/18/2025 **Status:** ✅ Merged **Merged:** 9/18/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `embed-404` --- ### 📝 Commits (1) - [`b798ba3`](https://github.com/koel/koel/commit/b798ba31d97b09afb0624f163f34a5c35b2bcf15) fix: proper error handle and other improvements for embeds ### 📊 Changes **23 files changed** (+496 additions, -123 deletions) <details> <summary>View changed files</summary> ➕ `app/Exceptions/EmbeddableNotFoundException.php` (+9 -0) 📝 `app/Http/Controllers/API/Embed/EmbedController.php` (+10 -4) 📝 `app/Repositories/SongRepository.php` (+3 -0) 📝 `resources/assets/js/components/embed/CreateEmbedForm.vue` (+1 -1) 📝 `resources/assets/js/components/embed/EmbedOptionsPanel.vue` (+0 -0) ➕ `resources/assets/js/components/embed/widget/EmbedWidget.spec.ts` (+93 -0) 📝 `resources/assets/js/components/embed/widget/EmbedWidget.vue` (+19 -111) ➕ `resources/assets/js/components/embed/widget/EmbedWidgetBanner.spec.ts` (+168 -0) ➕ `resources/assets/js/components/embed/widget/EmbedWidgetBanner.vue` (+65 -0) ➕ `resources/assets/js/components/embed/widget/EmbedWidgetErrorMessage.vue` (+8 -0) 📝 `resources/assets/js/components/embed/widget/EmbedWidgetThumbnail.spec.ts` (+2 -2) 📝 `resources/assets/js/components/embed/widget/EmbedWidgetThumbnail.vue` (+0 -0) 📝 `resources/assets/js/components/embed/widget/EmbedWidgetTrackItem.spec.ts` (+2 -2) 📝 `resources/assets/js/components/embed/widget/EmbedWidgetTrackItem.vue` (+0 -0) ➕ `resources/assets/js/components/embed/widget/EmbedWidgetTrackList.spec.ts` (+23 -0) ➕ `resources/assets/js/components/embed/widget/EmbedWidgetTrackList.vue` (+40 -0) ➕ `resources/assets/js/components/embed/widget/PreviewBadge.spec.ts` (+12 -0) ➕ `resources/assets/js/components/embed/widget/PreviewBadge.vue` (+10 -0) ➕ `resources/assets/js/components/embed/widget/__snapshots__/EmbedWidgetTrackItem.spec.ts.snap` (+13 -0) ➕ `resources/assets/js/components/embed/widget/__snapshots__/PreviewBadge.spec.ts.snap` (+3 -0) _...and 3 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:33:12 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#2074

No description provided.

Rows
Columns