[PR #2102] [MERGED] refactor: better types for modals and their contexts #2069

New issue

Closed

opened 2026-02-26 03:33:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:33:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2102
Author: @phanan
Created: 9/12/2025
Status: ✅ Merged
Merged: 9/12/2025
Merged by: @phanan

Base: master ← Head: modals

📝 Commits (1)

a1044df refactor: better types for modals and their contexts

📊 Changes

14 files changed (+97 additions, -63 deletions)

View changed files

📝 resources/assets/js/components/album/EditAlbumForm.vue (+1 -1)
📝 resources/assets/js/components/artist/EditArtistForm.vue (+1 -1)
📝 resources/assets/js/components/layout/ModalWrapper.vue (+48 -44)
📝 resources/assets/js/components/playable/EditSongForm.vue (+3 -3)
📝 resources/assets/js/components/playlist/CreatePlaylistForm.vue (+3 -3)
📝 resources/assets/js/components/playlist/EditPlaylistFolderForm.vue (+1 -1)
📝 resources/assets/js/components/playlist/EditPlaylistForm.vue (+1 -1)
📝 resources/assets/js/components/playlist/PlaylistCollaborationModal.vue (+1 -1)
📝 resources/assets/js/components/playlist/smart-playlist/CreateSmartPlaylistForm.vue (+1 -1)
📝 resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue (+1 -1)
📝 resources/assets/js/components/radio/EditRadioStationForm.vue (+1 -2)
📝 resources/assets/js/components/user/EditUserForm.vue (+1 -1)
📝 resources/assets/js/composables/useModal.ts (+13 -3)
➕ resources/assets/js/config/modals.ts (+21 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2102 **Author:** [@phanan](https://github.com/phanan) **Created:** 9/12/2025 **Status:** ✅ Merged **Merged:** 9/12/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `modals` --- ### 📝 Commits (1) - [`a1044df`](https://github.com/koel/koel/commit/a1044df20c8bebe2ef4f2d61e318882d36192096) refactor: better types for modals and their contexts ### 📊 Changes **14 files changed** (+97 additions, -63 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/album/EditAlbumForm.vue` (+1 -1) 📝 `resources/assets/js/components/artist/EditArtistForm.vue` (+1 -1) 📝 `resources/assets/js/components/layout/ModalWrapper.vue` (+48 -44) 📝 `resources/assets/js/components/playable/EditSongForm.vue` (+3 -3) 📝 `resources/assets/js/components/playlist/CreatePlaylistForm.vue` (+3 -3) 📝 `resources/assets/js/components/playlist/EditPlaylistFolderForm.vue` (+1 -1) 📝 `resources/assets/js/components/playlist/EditPlaylistForm.vue` (+1 -1) 📝 `resources/assets/js/components/playlist/PlaylistCollaborationModal.vue` (+1 -1) 📝 `resources/assets/js/components/playlist/smart-playlist/CreateSmartPlaylistForm.vue` (+1 -1) 📝 `resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue` (+1 -1) 📝 `resources/assets/js/components/radio/EditRadioStationForm.vue` (+1 -2) 📝 `resources/assets/js/components/user/EditUserForm.vue` (+1 -1) 📝 `resources/assets/js/composables/useModal.ts` (+13 -3) ➕ `resources/assets/js/config/modals.ts` (+21 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:33:11 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#2069

No description provided.

Rows
Columns