[PR #2003] [MERGED] refactor: use job instead of event for song folder extraction #2012

New issue

Closed

opened 2026-02-26 03:33:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:33:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2003
Author: @phanan
Created: 7/4/2025
Status: ✅ Merged
Merged: 7/4/2025
Merged by: @phanan

Base: master ← Head: job-facade

📝 Commits (2)

3435e20 refactor: use job instead of event for song folder extraction
a88cde1 feat: use Facade for dispatcher

📊 Changes

14 files changed (+127 additions, -141 deletions)

View changed files

➖ app/Events/SongFolderStructureExtractionRequested.php (+0 -12)
➕ app/Facades/Dispatcher.php (+18 -0)
📝 app/Http/Controllers/API/ScrobbleController.php (+4 -8)
📝 app/Http/Controllers/API/UploadController.php (+2 -3)
➕ app/Jobs/ExtractSongFolderStructureJob.php (+18 -0)
➖ app/Listeners/ExtractSongFolderStructure.php (+0 -19)
📝 app/Providers/EventServiceProvider.php (+0 -6)
📝 app/Services/SongService.php (+5 -5)
📝 config/app.php (+1 -0)
📝 tests/Feature/ScrobbleTest.php (+2 -3)
📝 tests/Feature/SongTest.php (+4 -20)
📝 tests/Integration/Services/Scanners/DirectoryScannerTest.php (+21 -47)
📝 tests/Integration/Services/Scanners/FileScannerTest.php (+37 -0)
📝 tests/Integration/Services/SongServiceTest.php (+15 -18)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2003 **Author:** [@phanan](https://github.com/phanan) **Created:** 7/4/2025 **Status:** ✅ Merged **Merged:** 7/4/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `job-facade` --- ### 📝 Commits (2) - [`3435e20`](https://github.com/koel/koel/commit/3435e20c4f18dacef81881493a053e0bbae6770a) refactor: use job instead of event for song folder extraction - [`a88cde1`](https://github.com/koel/koel/commit/a88cde1f721bdf0ce390a52ba2d54e3103582c81) feat: use Facade for dispatcher ### 📊 Changes **14 files changed** (+127 additions, -141 deletions) <details> <summary>View changed files</summary> ➖ `app/Events/SongFolderStructureExtractionRequested.php` (+0 -12) ➕ `app/Facades/Dispatcher.php` (+18 -0) 📝 `app/Http/Controllers/API/ScrobbleController.php` (+4 -8) 📝 `app/Http/Controllers/API/UploadController.php` (+2 -3) ➕ `app/Jobs/ExtractSongFolderStructureJob.php` (+18 -0) ➖ `app/Listeners/ExtractSongFolderStructure.php` (+0 -19) 📝 `app/Providers/EventServiceProvider.php` (+0 -6) 📝 `app/Services/SongService.php` (+5 -5) 📝 `config/app.php` (+1 -0) 📝 `tests/Feature/ScrobbleTest.php` (+2 -3) 📝 `tests/Feature/SongTest.php` (+4 -20) 📝 `tests/Integration/Services/Scanners/DirectoryScannerTest.php` (+21 -47) 📝 `tests/Integration/Services/Scanners/FileScannerTest.php` (+37 -0) 📝 `tests/Integration/Services/SongServiceTest.php` (+15 -18) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:33:02 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:33:03 +03:00

[PR #2014] [MERGED] feat: option to include/exclude publicly shared media #2019

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#2012

No description provided.

Rows
Columns