[PR #2002] [MERGED] refactor: use enum for playable moving placement #2010

Closed
opened 2026-02-26 03:33:01 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/2002
Author: @phanan
Created: 7/4/2025
Status: Merged
Merged: 7/4/2025
Merged by: @phanan

Base: masterHead: move-placement


📝 Commits (1)

  • 3bd6333 refactor: use enum for playable moving placement

📊 Changes

12 files changed (+63 additions, -36 deletions)

View changed files

app/Enums/Placement.php (+9 -0)
📝 app/Http/Controllers/API/MovePlaylistSongsController.php (+7 -1)
📝 app/Http/Requests/API/MovePlaylistSongsRequest.php (+5 -2)
📝 app/Services/PlaylistService.php (+11 -6)
📝 resources/assets/js/components/screens/PlaylistScreen.vue (+3 -5)
📝 resources/assets/js/components/screens/QueueScreen.vue (+6 -1)
📝 resources/assets/js/components/song/song-list/SongList.vue (+1 -1)
📝 resources/assets/js/stores/playlistStore.ts (+9 -4)
📝 resources/assets/js/stores/queueStore.ts (+2 -2)
📝 resources/assets/js/types.d.ts (+1 -1)
📝 resources/assets/js/utils/helpers.ts (+4 -9)
📝 tests/Integration/Services/PlaylistServiceTest.php (+5 -4)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/2002 **Author:** [@phanan](https://github.com/phanan) **Created:** 7/4/2025 **Status:** ✅ Merged **Merged:** 7/4/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `move-placement` --- ### 📝 Commits (1) - [`3bd6333`](https://github.com/koel/koel/commit/3bd6333ff92177c381be18f2ccefd099ec117c00) refactor: use enum for playable moving placement ### 📊 Changes **12 files changed** (+63 additions, -36 deletions) <details> <summary>View changed files</summary> ➕ `app/Enums/Placement.php` (+9 -0) 📝 `app/Http/Controllers/API/MovePlaylistSongsController.php` (+7 -1) 📝 `app/Http/Requests/API/MovePlaylistSongsRequest.php` (+5 -2) 📝 `app/Services/PlaylistService.php` (+11 -6) 📝 `resources/assets/js/components/screens/PlaylistScreen.vue` (+3 -5) 📝 `resources/assets/js/components/screens/QueueScreen.vue` (+6 -1) 📝 `resources/assets/js/components/song/song-list/SongList.vue` (+1 -1) 📝 `resources/assets/js/stores/playlistStore.ts` (+9 -4) 📝 `resources/assets/js/stores/queueStore.ts` (+2 -2) 📝 `resources/assets/js/types.d.ts` (+1 -1) 📝 `resources/assets/js/utils/helpers.ts` (+4 -9) 📝 `tests/Integration/Services/PlaylistServiceTest.php` (+5 -4) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:33:01 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#2010
No description provided.