[PR #1986] [MERGED] fix: artwork download logic #2000

New issue

Closed

opened 2026-02-26 03:33:00 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:33:00 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1986
Author: @phanan
Created: 7/2/2025
Status: ✅ Merged
Merged: 7/2/2025
Merged by: @phanan

Base: master ← Head: fix-artwork-download

📝 Commits (1)

f56a833 fix: artwork download logic

📊 Changes

52 files changed (+294 additions, -367 deletions)

View changed files

📝 app/Services/EncyclopediaService.php (+2 -2)
📝 phpstan.neon.dist (+0 -4)
📝 tests/Concerns/CreatesApplication.php (+1 -1)
📝 tests/Concerns/MakesHttpRequests.php (+1 -1)
➕ tests/Concerns/TestsPipelines.php (+15 -0)
📝 tests/Feature/AlbumInformationTest.php (+1 -1)
📝 tests/Feature/AlbumThumbnailTest.php (+1 -2)
📝 tests/Feature/ArtistInformationTest.php (+1 -1)
📝 tests/Feature/DownloadTest.php (+6 -12)
📝 tests/Feature/ForgotPasswordTest.php (+2 -2)
📝 tests/Feature/KoelPlus/ArtistImageTest.php (+1 -1)
📝 tests/Feature/KoelPlus/DownloadTest.php (+2 -4)
📝 tests/Feature/KoelPlus/SSO/GoogleTest.php (+3 -3)
📝 tests/Feature/KoelPlus/SongPlayTest.php (+2 -4)
📝 tests/Feature/LastfmTest.php (+9 -11)
📝 tests/Feature/ScrobbleTest.php (+2 -3)
📝 tests/Feature/SettingTest.php (+1 -1)
📝 tests/Feature/SongPlayTest.php (+3 -6)
📝 tests/Feature/YouTubeTest.php (+2 -3)
📝 tests/Integration/Jobs/RunCommandJobTest.php (+1 -2)

...and 32 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1986 **Author:** [@phanan](https://github.com/phanan) **Created:** 7/2/2025 **Status:** ✅ Merged **Merged:** 7/2/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix-artwork-download` --- ### 📝 Commits (1) - [`f56a833`](https://github.com/koel/koel/commit/f56a833e5797e4ae8ac70de826d48ba97b029be6) fix: artwork download logic ### 📊 Changes **52 files changed** (+294 additions, -367 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/EncyclopediaService.php` (+2 -2) 📝 `phpstan.neon.dist` (+0 -4) 📝 `tests/Concerns/CreatesApplication.php` (+1 -1) 📝 `tests/Concerns/MakesHttpRequests.php` (+1 -1) ➕ `tests/Concerns/TestsPipelines.php` (+15 -0) 📝 `tests/Feature/AlbumInformationTest.php` (+1 -1) 📝 `tests/Feature/AlbumThumbnailTest.php` (+1 -2) 📝 `tests/Feature/ArtistInformationTest.php` (+1 -1) 📝 `tests/Feature/DownloadTest.php` (+6 -12) 📝 `tests/Feature/ForgotPasswordTest.php` (+2 -2) 📝 `tests/Feature/KoelPlus/ArtistImageTest.php` (+1 -1) 📝 `tests/Feature/KoelPlus/DownloadTest.php` (+2 -4) 📝 `tests/Feature/KoelPlus/SSO/GoogleTest.php` (+3 -3) 📝 `tests/Feature/KoelPlus/SongPlayTest.php` (+2 -4) 📝 `tests/Feature/LastfmTest.php` (+9 -11) 📝 `tests/Feature/ScrobbleTest.php` (+2 -3) 📝 `tests/Feature/SettingTest.php` (+1 -1) 📝 `tests/Feature/SongPlayTest.php` (+3 -6) 📝 `tests/Feature/YouTubeTest.php` (+2 -3) 📝 `tests/Integration/Jobs/RunCommandJobTest.php` (+1 -2) _...and 32 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:33:00 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#2000

No description provided.

Rows
Columns