[PR #1980] [MERGED] fix: types and a drag-n-drop bug #1995

New issue

Closed

opened 2026-02-26 03:32:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1980
Author: @phanan
Created: 6/29/2025
Status: ✅ Merged
Merged: 6/29/2025
Merged by: @phanan

Base: master ← Head: types

📝 Commits (1)

1e3a941 fix: types and a drag-n-drop bug

📊 Changes

38 files changed (+136 additions, -96 deletions)

View changed files

📝 pnpm-lock.yaml (+1 -1)
📝 resources/assets/js/__tests__/factory/albumFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/albumInfoFactory.ts (+3 -3)
📝 resources/assets/js/__tests__/factory/albumTrackFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/artistFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/artistInfoFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/episodeFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/folderFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/genreFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/index.ts (+2 -6)
📝 resources/assets/js/__tests__/factory/interactionFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/playlistCollaboratorFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/playlistFactory.ts (+6 -6)
📝 resources/assets/js/__tests__/factory/playlistFolderFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/podcastFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/smartPlaylistRuleFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/smartPlaylistRuleGroupFactory.ts (+3 -3)
📝 resources/assets/js/__tests__/factory/userFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/youTubeVideoFactory.ts (+2 -2)
📝 resources/assets/js/components/screens/PlaylistScreen.vue (+2 -2)

...and 18 more files

📄 Description

Multiple type errors since the last time we strict checked ;)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1980 **Author:** [@phanan](https://github.com/phanan) **Created:** 6/29/2025 **Status:** ✅ Merged **Merged:** 6/29/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `types` --- ### 📝 Commits (1) - [`1e3a941`](https://github.com/koel/koel/commit/1e3a94157180805f3764c0729cea118e2a45f0ec) fix: types and a drag-n-drop bug ### 📊 Changes **38 files changed** (+136 additions, -96 deletions) <details> <summary>View changed files</summary> 📝 `pnpm-lock.yaml` (+1 -1) 📝 `resources/assets/js/__tests__/factory/albumFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/albumInfoFactory.ts` (+3 -3) 📝 `resources/assets/js/__tests__/factory/albumTrackFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/artistFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/artistInfoFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/episodeFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/folderFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/genreFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/index.ts` (+2 -6) 📝 `resources/assets/js/__tests__/factory/interactionFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/playlistCollaboratorFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/playlistFactory.ts` (+6 -6) 📝 `resources/assets/js/__tests__/factory/playlistFolderFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/podcastFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/smartPlaylistRuleFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/smartPlaylistRuleGroupFactory.ts` (+3 -3) 📝 `resources/assets/js/__tests__/factory/userFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/youTubeVideoFactory.ts` (+2 -2) 📝 `resources/assets/js/components/screens/PlaylistScreen.vue` (+2 -2) _...and 18 more files_ </details> ### 📄 Description Multiple type errors since the last time we strict checked ;) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:59 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:33:01 +03:00

[PR #1995] [MERGED] fix: playlist songs reordering #2008

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1995

No description provided.

Rows
Columns