[PR #1974] [MERGED] feat: use jobs instead of direct command for scheduled tasks #1991

New issue

Closed

opened 2026-02-26 03:32:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1974
Author: @phanan
Created: 6/27/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @phanan

Base: master ← Head: job-schedule

📝 Commits (1)

20ab82b feat: use jobs instead of direct command for scheduled tasks

📊 Changes

10 files changed (+65 additions, -30 deletions)

View changed files

📝 app/Jobs/DeleteSongFilesJob.php (+1 -1)
📝 app/Jobs/DeleteTranscodeFilesJob.php (+1 -1)
➕ app/Jobs/RunCommandJob.php (+17 -0)
📝 app/Services/SongService.php (+4 -4)
📝 routes/console.php (+5 -8)
📝 tests/Feature/SongTest.php (+3 -3)
➕ tests/Integration/Jobs/RunCommandJobTest.php (+21 -0)
📝 tests/Integration/Services/SongServiceTest.php (+9 -9)
📝 tests/Unit/Jobs/DeleteSongFilesJobTest.php (+2 -2)
📝 tests/Unit/Jobs/DeleteTranscodeFilesJobTest.php (+2 -2)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1974 **Author:** [@phanan](https://github.com/phanan) **Created:** 6/27/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `job-schedule` --- ### 📝 Commits (1) - [`20ab82b`](https://github.com/koel/koel/commit/20ab82b0d0846222a8023aa58036632e8cf5ca68) feat: use jobs instead of direct command for scheduled tasks ### 📊 Changes **10 files changed** (+65 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `app/Jobs/DeleteSongFilesJob.php` (+1 -1) 📝 `app/Jobs/DeleteTranscodeFilesJob.php` (+1 -1) ➕ `app/Jobs/RunCommandJob.php` (+17 -0) 📝 `app/Services/SongService.php` (+4 -4) 📝 `routes/console.php` (+5 -8) 📝 `tests/Feature/SongTest.php` (+3 -3) ➕ `tests/Integration/Jobs/RunCommandJobTest.php` (+21 -0) 📝 `tests/Integration/Services/SongServiceTest.php` (+9 -9) 📝 `tests/Unit/Jobs/DeleteSongFilesJobTest.php` (+2 -2) 📝 `tests/Unit/Jobs/DeleteTranscodeFilesJobTest.php` (+2 -2) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:58 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:33:00 +03:00

[PR #1991] [MERGED] fix: local deletion of song files #2004

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1991

No description provided.

Rows
Columns