[PR #1973] [MERGED] chore: switch from uuid to ulid where applicable #1989

Closed
opened 2026-02-26 03:32:57 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1973
Author: @phanan
Created: 6/27/2025
Status: Merged
Merged: 6/27/2025
Merged by: @phanan

Base: masterHead: ulid


📝 Commits (1)

  • 5b7d8d4 chore: switch from uuid to ulid where applicable

📊 Changes

16 files changed (+97 additions, -92 deletions)

View changed files

📝 app/Console/Commands/Storage/SetupDropboxStorageCommand.php (+2 -2)
📝 app/Helpers/TestableIdentifier.php (+18 -3)
📝 app/Helpers/Ulid.php (+2 -9)
📝 app/Helpers/Uuid.php (+2 -9)
📝 app/Models/PlaylistCollaborationToken.php (+2 -2)
📝 app/Models/User.php (+2 -2)
📝 app/Services/MediaMetadataService.php (+4 -4)
📝 app/Services/PodcastService.php (+2 -2)
📝 app/Services/SongStorages/LocalStorage.php (+2 -1)
📝 app/Services/UserInvitationService.php (+2 -2)
📝 app/Services/UserService.php (+2 -1)
📝 app/Values/SmartPlaylist/SmartPlaylistRule.php (+2 -2)
📝 tests/Integration/KoelPlus/Services/SmartPlaylistServiceTest.php (+3 -3)
📝 tests/Integration/Services/SmartPlaylistServiceTest.php (+43 -42)
📝 tests/Integration/Services/Transcoding/LocalTranscodingStrategyTest.php (+4 -3)
📝 tests/Integration/Services/Transcoding/SfpTranscodingStrategyTest.php (+5 -5)

📄 Description

Because ULID is just shorter.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1973 **Author:** [@phanan](https://github.com/phanan) **Created:** 6/27/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `ulid` --- ### 📝 Commits (1) - [`5b7d8d4`](https://github.com/koel/koel/commit/5b7d8d44502206ad7184ecf6c5f39e6d43238694) chore: switch from uuid to ulid where applicable ### 📊 Changes **16 files changed** (+97 additions, -92 deletions) <details> <summary>View changed files</summary> 📝 `app/Console/Commands/Storage/SetupDropboxStorageCommand.php` (+2 -2) 📝 `app/Helpers/TestableIdentifier.php` (+18 -3) 📝 `app/Helpers/Ulid.php` (+2 -9) 📝 `app/Helpers/Uuid.php` (+2 -9) 📝 `app/Models/PlaylistCollaborationToken.php` (+2 -2) 📝 `app/Models/User.php` (+2 -2) 📝 `app/Services/MediaMetadataService.php` (+4 -4) 📝 `app/Services/PodcastService.php` (+2 -2) 📝 `app/Services/SongStorages/LocalStorage.php` (+2 -1) 📝 `app/Services/UserInvitationService.php` (+2 -2) 📝 `app/Services/UserService.php` (+2 -1) 📝 `app/Values/SmartPlaylist/SmartPlaylistRule.php` (+2 -2) 📝 `tests/Integration/KoelPlus/Services/SmartPlaylistServiceTest.php` (+3 -3) 📝 `tests/Integration/Services/SmartPlaylistServiceTest.php` (+43 -42) 📝 `tests/Integration/Services/Transcoding/LocalTranscodingStrategyTest.php` (+4 -3) 📝 `tests/Integration/Services/Transcoding/SfpTranscodingStrategyTest.php` (+5 -5) </details> ### 📄 Description Because ULID is just shorter. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:57 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1989
No description provided.