[PR #1965] [MERGED] refactor: decouple song creation from scanning #1987

New issue

Closed

opened 2026-02-26 03:32:57 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1965
Author: @phanan
Created: 6/22/2025
Status: ✅ Merged
Merged: 6/22/2025
Merged by: @phanan

Base: master ← Head: decouple-file-song

📝 Commits (2)

55d6656 chore: update the tagline
1dd9dbb refactor: decouple song creation from scanning

📊 Changes

61 files changed (+845 additions, -804 deletions)

View changed files

📝 app/Builders/SongBuilder.php (+3 -0)
📝 app/Console/Commands/ScanCommand.php (+17 -13)
📝 app/Events/Event.php (+4 -0)
📝 app/Events/MediaScanCompleted.php (+0 -3)
📝 app/Events/MultipleSongsLiked.php (+0 -3)
📝 app/Events/MultipleSongsUnliked.php (+0 -3)
📝 app/Events/NewPlaylistCollaboratorJoined.php (+0 -3)
📝 app/Events/PlaybackStarted.php (+0 -3)
➕ app/Events/SongFolderStructureExtractionRequested.php (+12 -0)
📝 app/Events/SongLikeToggled.php (+0 -3)
📝 app/Helpers.php (+13 -0)
📝 app/Http/Controllers/API/SettingController.php (+5 -4)
📝 app/Listeners/DeleteNonExistingRecordsPostScan.php (+3 -2)
➕ app/Listeners/ExtractSongFolderStructure.php (+19 -0)
📝 app/Listeners/LoveMultipleTracksOnLastfm.php (+2 -2)
📝 app/Listeners/LoveTrackOnLastfm.php (+2 -2)
📝 app/Listeners/MakePlaylistSongsPublic.php (+2 -2)
📝 app/Listeners/PruneLibrary.php (+3 -2)
📝 app/Listeners/UnloveMultipleTracksOnLastfm.php (+2 -2)
📝 app/Listeners/UpdateLastfmNowPlaying.php (+2 -2)

...and 41 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1965 **Author:** [@phanan](https://github.com/phanan) **Created:** 6/22/2025 **Status:** ✅ Merged **Merged:** 6/22/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `decouple-file-song` --- ### 📝 Commits (2) - [`55d6656`](https://github.com/koel/koel/commit/55d6656452212d6d768281f1ac15eb00b9488052) chore: update the tagline - [`1dd9dbb`](https://github.com/koel/koel/commit/1dd9dbb70a7227dbbb5082d26825eb4672d0a7e9) refactor: decouple song creation from scanning ### 📊 Changes **61 files changed** (+845 additions, -804 deletions) <details> <summary>View changed files</summary> 📝 `app/Builders/SongBuilder.php` (+3 -0) 📝 `app/Console/Commands/ScanCommand.php` (+17 -13) 📝 `app/Events/Event.php` (+4 -0) 📝 `app/Events/MediaScanCompleted.php` (+0 -3) 📝 `app/Events/MultipleSongsLiked.php` (+0 -3) 📝 `app/Events/MultipleSongsUnliked.php` (+0 -3) 📝 `app/Events/NewPlaylistCollaboratorJoined.php` (+0 -3) 📝 `app/Events/PlaybackStarted.php` (+0 -3) ➕ `app/Events/SongFolderStructureExtractionRequested.php` (+12 -0) 📝 `app/Events/SongLikeToggled.php` (+0 -3) 📝 `app/Helpers.php` (+13 -0) 📝 `app/Http/Controllers/API/SettingController.php` (+5 -4) 📝 `app/Listeners/DeleteNonExistingRecordsPostScan.php` (+3 -2) ➕ `app/Listeners/ExtractSongFolderStructure.php` (+19 -0) 📝 `app/Listeners/LoveMultipleTracksOnLastfm.php` (+2 -2) 📝 `app/Listeners/LoveTrackOnLastfm.php` (+2 -2) 📝 `app/Listeners/MakePlaylistSongsPublic.php` (+2 -2) 📝 `app/Listeners/PruneLibrary.php` (+3 -2) 📝 `app/Listeners/UnloveMultipleTracksOnLastfm.php` (+2 -2) 📝 `app/Listeners/UpdateLastfmNowPlaying.php` (+2 -2) _...and 41 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:57 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:33:00 +03:00

[PR #1987] [MERGED] fix: incorrect identification of successful scans #2002

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1987

No description provided.

Rows
Columns