mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[PR #1911] [CLOSED] feat: album release year data and album list sort modes #1949
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1949
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1911
Author: @Jacob-Noah
Created: 4/5/2025
Status: ❌ Closed
Base:
master← Head:feat/album-year📝 Commits (4)
0397da2feat: add album release year to model/viewsd59ec68feat: add album list sort modesefd9966Merge branch 'koel:master' into feat/album-year8559e32Merge branch 'master' into feat/album-year📊 Changes
15 files changed (+167 additions, -9 deletions)
View changed files
➕
app/Console/Commands/UpdateAlbumReleaseYears.php(+34 -0)📝
app/Http/Controllers/API/AlbumController.php(+4 -2)📝
app/Http/Resources/AlbumResource.php(+2 -0)📝
app/Models/Album.php(+1 -1)📝
app/Repositories/AlbumRepository.php(+5 -2)📝
app/Services/FileScanner.php(+21 -0)📝
app/Values/UserPreferences.php(+5 -0)➕
database/migrations/2025_04_04_213046_add_release_year_to_albums_table.php(+18 -0)📝
resources/assets/js/components/album/AlbumCard.vue(+1 -0)📝
resources/assets/js/components/screens/AlbumListScreen.vue(+16 -2)📝
resources/assets/js/components/screens/AlbumScreen.vue(+1 -0)➕
resources/assets/js/components/ui/AlbumSortModeSwitch.vue(+49 -0)📝
resources/assets/js/stores/albumStore.ts(+5 -2)📝
resources/assets/js/stores/preferenceStore.ts(+1 -0)📝
resources/assets/js/types.d.ts(+4 -0)📄 Description
With great pleasure I contribute my most desired feature and one that I believe would assist many music collectors' efforts in transitioning to Koel, #1894. For simplicity's sake I absorb the release year for albums from the first track's metadata. This enables the ability to display them and add sort modes to the album list. I'm pretty happy with the results:
Pagination otherwise works as normal, as well as the album view mode options. I added a command for collecting the release year for existing libraries, it's just a little long because it's got such a specific use-case, but it could also be done as part of the migration if desired. All tests passed locally for me except for filesystem related tests that I assume require Linux.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.