[PR #1918] [MERGED] refactor: strong types and more tests for StreamerAdapter #1946

New issue

Closed

opened 2026-02-26 03:32:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1918
Author: @phanan
Created: 5/12/2025
Status: ✅ Merged
Merged: 5/12/2025
Merged by: @phanan

Base: master ← Head: stream-adapter-refactor

📝 Commits (1)

d3caa05 refactor: strong types and more tests for StreamerAdapter

📊 Changes

15 files changed (+93 additions, -42 deletions)

View changed files

📝 app/Http/Controllers/PlayController.php (+9 -5)
📝 app/Services/Streamer/Adapters/DropboxStreamerAdapter.php (+2 -1)
📝 app/Services/Streamer/Adapters/PhpStreamerAdapter.php (+2 -1)
📝 app/Services/Streamer/Adapters/PodcastStreamerAdapter.php (+2 -1)
📝 app/Services/Streamer/Adapters/S3CompatibleStreamerAdapter.php (+2 -1)
📝 app/Services/Streamer/Adapters/SftpStreamerAdapter.php (+2 -1)
📝 app/Services/Streamer/Adapters/StreamerAdapter.php (+2 -1)
📝 app/Services/Streamer/Adapters/TranscodingStreamerAdapter.php (+3 -4)
📝 app/Services/Streamer/Adapters/XAccelRedirectStreamerAdapter.php (+3 -2)
📝 app/Services/Streamer/Adapters/XSendFileStreamerAdapter.php (+2 -1)
📝 app/Services/Streamer/Streamer.php (+7 -7)
➕ app/Values/RequestedStreamingConfig.php (+18 -0)
📝 resources/assets/js/components/song/song-list/SongListItem.vue (+1 -1)
📝 tests/Integration/KoelPlus/Services/Streamer/StreamerTest.php (+1 -2)
📝 tests/Integration/Services/Streamer/StreamerTest.php (+37 -14)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1918 **Author:** [@phanan](https://github.com/phanan) **Created:** 5/12/2025 **Status:** ✅ Merged **Merged:** 5/12/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `stream-adapter-refactor` --- ### 📝 Commits (1) - [`d3caa05`](https://github.com/koel/koel/commit/d3caa05479018915a75f9b8b71f12e8fb3c36ee7) refactor: strong types and more tests for StreamerAdapter ### 📊 Changes **15 files changed** (+93 additions, -42 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/PlayController.php` (+9 -5) 📝 `app/Services/Streamer/Adapters/DropboxStreamerAdapter.php` (+2 -1) 📝 `app/Services/Streamer/Adapters/PhpStreamerAdapter.php` (+2 -1) 📝 `app/Services/Streamer/Adapters/PodcastStreamerAdapter.php` (+2 -1) 📝 `app/Services/Streamer/Adapters/S3CompatibleStreamerAdapter.php` (+2 -1) 📝 `app/Services/Streamer/Adapters/SftpStreamerAdapter.php` (+2 -1) 📝 `app/Services/Streamer/Adapters/StreamerAdapter.php` (+2 -1) 📝 `app/Services/Streamer/Adapters/TranscodingStreamerAdapter.php` (+3 -4) 📝 `app/Services/Streamer/Adapters/XAccelRedirectStreamerAdapter.php` (+3 -2) 📝 `app/Services/Streamer/Adapters/XSendFileStreamerAdapter.php` (+2 -1) 📝 `app/Services/Streamer/Streamer.php` (+7 -7) ➕ `app/Values/RequestedStreamingConfig.php` (+18 -0) 📝 `resources/assets/js/components/song/song-list/SongListItem.vue` (+1 -1) 📝 `tests/Integration/KoelPlus/Services/Streamer/StreamerTest.php` (+1 -2) 📝 `tests/Integration/Services/Streamer/StreamerTest.php` (+37 -14) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:55 +03:00

[PR #1946] [MERGED] feat: separate albums and artists by users #1970

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1946

No description provided.

Rows
Columns