[PR #1909] [MERGED] fix: various broken tests #1944

New issue

Closed

opened 2026-02-26 03:32:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1909
Author: @phanan
Created: 3/17/2025
Status: ✅ Merged
Merged: 3/17/2025
Merged by: @phanan

Base: master ← Head: no-exit

📝 Commits (1)

1b06888 fix: no exit when stream local paths

📊 Changes

12 files changed (+46 additions, -15 deletions)

View changed files

📝 .github/workflows/unit-backend-mysql.yml (+5 -1)
📝 .github/workflows/unit-backend-pgsql.yml (+5 -1)
📝 .github/workflows/unit-backend.yml (+5 -1)
📝 app/Services/Streamer/Adapters/Concerns/StreamsLocalPath.php (+1 -3)
📝 app/Services/Streamer/Adapters/PodcastStreamerAdapter.php (+2 -2)
📝 app/Services/Streamer/Adapters/XAccelRedirectStreamerAdapter.php (+0 -2)
📝 app/Services/Streamer/Adapters/XSendFileStreamerAdapter.php (+0 -2)
📝 app/Services/Streamer/Streamer.php (+6 -1)
📝 tests/Feature/KoelPlus/ProxyAuthTest.php (+1 -1)
📝 tests/Feature/SongPlayTest.php (+15 -0)
📝 tests/Unit/Services/PlaylistFolderServiceTest.php (+1 -1)
📝 tests/Unit/Services/SongStorages/DropboxStorageTest.php (+5 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1909 **Author:** [@phanan](https://github.com/phanan) **Created:** 3/17/2025 **Status:** ✅ Merged **Merged:** 3/17/2025 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `no-exit` --- ### 📝 Commits (1) - [`1b06888`](https://github.com/koel/koel/commit/1b0688853944918880ab6b189d28b5e2d340bb06) fix: no exit when stream local paths ### 📊 Changes **12 files changed** (+46 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/unit-backend-mysql.yml` (+5 -1) 📝 `.github/workflows/unit-backend-pgsql.yml` (+5 -1) 📝 `.github/workflows/unit-backend.yml` (+5 -1) 📝 `app/Services/Streamer/Adapters/Concerns/StreamsLocalPath.php` (+1 -3) 📝 `app/Services/Streamer/Adapters/PodcastStreamerAdapter.php` (+2 -2) 📝 `app/Services/Streamer/Adapters/XAccelRedirectStreamerAdapter.php` (+0 -2) 📝 `app/Services/Streamer/Adapters/XSendFileStreamerAdapter.php` (+0 -2) 📝 `app/Services/Streamer/Streamer.php` (+6 -1) 📝 `tests/Feature/KoelPlus/ProxyAuthTest.php` (+1 -1) 📝 `tests/Feature/SongPlayTest.php` (+15 -0) 📝 `tests/Unit/Services/PlaylistFolderServiceTest.php` (+1 -1) 📝 `tests/Unit/Services/SongStorages/DropboxStorageTest.php` (+5 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:54 +03:00

[PR #1944] [MERGED] feat: support transcoding for non-local songs #1968

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1944

No description provided.

Rows
Columns