[PR #1874] [MERGED] refactor: avoid leadking database keys #1930

Closed
opened 2026-02-26 03:32:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1874
Author: @phanan
Created: 11/9/2024
Status: Merged
Merged: 11/9/2024
Merged by: @phanan

Base: masterHead: hide-ids


📝 Commits (1)

  • bf436a2 refactor: avoid leadking database keys

📊 Changes

76 files changed (+288 additions, -295 deletions)

View changed files

📝 app/Console/Commands/Admin/ChangePasswordCommand.php (+1 -1)
📝 app/Console/Commands/ScanCommand.php (+2 -2)
📝 app/Exceptions/UserAlreadySubscribedToPodcast.php (+1 -1)
📝 app/Http/Controllers/API/PrivatizeSongsController.php (+3 -0)
📝 app/Http/Controllers/API/PublicizeSongsController.php (+3 -0)
📝 app/Http/Controllers/API/UploadAlbumCoverController.php (+1 -1)
📝 app/Http/Controllers/API/UploadArtistImageController.php (+1 -1)
📝 app/Http/Requests/API/ProfileUpdateRequest.php (+1 -1)
📝 app/Models/Album.php (+0 -1)
📝 app/Models/Playlist.php (+6 -5)
📝 app/Models/PlaylistFolder.php (+1 -2)
📝 app/Models/Song.php (+1 -0)
📝 app/Models/User.php (+1 -1)
📝 app/Policies/SongPolicy.php (+1 -0)
📝 app/Providers/MacroProvider.php (+1 -1)
📝 app/Repositories/AlbumRepository.php (+1 -1)
📝 app/Repositories/ArtistRepository.php (+1 -2)
📝 app/Repositories/Contracts/RepositoryInterface.php (+2 -3)
📝 app/Repositories/PodcastRepository.php (+1 -1)
📝 app/Repositories/Repository.php (+3 -4)

...and 56 more files

📄 Description

Inspired by this tweet.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1874 **Author:** [@phanan](https://github.com/phanan) **Created:** 11/9/2024 **Status:** ✅ Merged **Merged:** 11/9/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `hide-ids` --- ### 📝 Commits (1) - [`bf436a2`](https://github.com/koel/koel/commit/bf436a28f8a722b506908ff2bab28f0eb71364a5) refactor: avoid leadking database keys ### 📊 Changes **76 files changed** (+288 additions, -295 deletions) <details> <summary>View changed files</summary> 📝 `app/Console/Commands/Admin/ChangePasswordCommand.php` (+1 -1) 📝 `app/Console/Commands/ScanCommand.php` (+2 -2) 📝 `app/Exceptions/UserAlreadySubscribedToPodcast.php` (+1 -1) 📝 `app/Http/Controllers/API/PrivatizeSongsController.php` (+3 -0) 📝 `app/Http/Controllers/API/PublicizeSongsController.php` (+3 -0) 📝 `app/Http/Controllers/API/UploadAlbumCoverController.php` (+1 -1) 📝 `app/Http/Controllers/API/UploadArtistImageController.php` (+1 -1) 📝 `app/Http/Requests/API/ProfileUpdateRequest.php` (+1 -1) 📝 `app/Models/Album.php` (+0 -1) 📝 `app/Models/Playlist.php` (+6 -5) 📝 `app/Models/PlaylistFolder.php` (+1 -2) 📝 `app/Models/Song.php` (+1 -0) 📝 `app/Models/User.php` (+1 -1) 📝 `app/Policies/SongPolicy.php` (+1 -0) 📝 `app/Providers/MacroProvider.php` (+1 -1) 📝 `app/Repositories/AlbumRepository.php` (+1 -1) 📝 `app/Repositories/ArtistRepository.php` (+1 -2) 📝 `app/Repositories/Contracts/RepositoryInterface.php` (+2 -3) 📝 `app/Repositories/PodcastRepository.php` (+1 -1) 📝 `app/Repositories/Repository.php` (+3 -4) _...and 56 more files_ </details> ### 📄 Description Inspired by [this tweet](https://x.com/i/bookmarks?post_id=1854557758344823285). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:47 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1930
No description provided.