[PR #1869] [MERGED] feat: always show song list header action menu #1928

Closed
opened 2026-02-26 03:32:47 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1869
Author: @phanan
Created: 10/31/2024
Status: Merged
Merged: 10/31/2024
Merged by: @phanan

Base: masterHead: allow-column-vis-anywhere


📝 Commits (1)

  • f52eea4 feat: always show song list header action menu

📊 Changes

5 files changed (+30 additions, -10 deletions)

View changed files

📝 resources/assets/js/components/song/song-list/SongListHeader.spec.ts (+1 -1)
📝 resources/assets/js/components/song/song-list/SongListHeader.vue (+4 -4)
📝 resources/assets/js/components/song/song-list/SongListHeaderActionMenu.spec.ts (+18 -1)
📝 resources/assets/js/components/song/song-list/SongListHeaderActionMenu.vue (+6 -3)
📝 resources/assets/js/components/song/song-list/__snapshots__/SongListHeader.spec.ts.snap (+1 -1)

📄 Description

Now that the "SongListSorter" has expanded its functionality to both a sorter and a column picker, it should be renamed accordingly and always shown.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1869 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/31/2024 **Status:** ✅ Merged **Merged:** 10/31/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `allow-column-vis-anywhere` --- ### 📝 Commits (1) - [`f52eea4`](https://github.com/koel/koel/commit/f52eea4a582ca49587b1acbc52312d991399bb41) feat: always show song list header action menu ### 📊 Changes **5 files changed** (+30 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/song/song-list/SongListHeader.spec.ts` (+1 -1) 📝 `resources/assets/js/components/song/song-list/SongListHeader.vue` (+4 -4) 📝 `resources/assets/js/components/song/song-list/SongListHeaderActionMenu.spec.ts` (+18 -1) 📝 `resources/assets/js/components/song/song-list/SongListHeaderActionMenu.vue` (+6 -3) 📝 `resources/assets/js/components/song/song-list/__snapshots__/SongListHeader.spec.ts.snap` (+1 -1) </details> ### 📄 Description Now that the "SongListSorter" has expanded its functionality to both a sorter and a column picker, it should be renamed accordingly and always shown. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:47 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1928
No description provided.