[PR #1864] [MERGED] fix: song controls disappear during filtering #1921

New issue

Closed

opened 2026-02-26 03:32:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1864
Author: @phanan
Created: 10/28/2024
Status: ✅ Merged
Merged: 10/28/2024
Merged by: @phanan

Base: master ← Head: fix/controls

📝 Commits (1)

a912f4e fix: song controls disappear during filtering

📊 Changes

9 files changed (+32 additions, -17 deletions)

View changed files

📝 resources/assets/js/__tests__/UnitTestCase.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/podcastFactory.ts (+1 -1)
📝 resources/assets/js/components/screens/PlaylistScreen.vue (+5 -0)
📝 resources/assets/js/components/song/song-list/SongList.spec.ts (+2 -2)
📝 resources/assets/js/components/song/song-list/SongList.vue (+2 -2)
📝 resources/assets/js/components/song/song-list/SongListControls.spec.ts (+2 -1)
📝 resources/assets/js/components/song/song-list/SongListControls.vue (+6 -5)
📝 resources/assets/js/composables/useSongList.ts (+10 -3)
📝 resources/assets/js/symbols.ts (+2 -1)

📄 Description

Song controls disappear if the filter returns an empty result set, since we are relying on the number of songs returned. Fixing by relying on the number of original songs before filtering instead.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1864 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/28/2024 **Status:** ✅ Merged **Merged:** 10/28/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix/controls` --- ### 📝 Commits (1) - [`a912f4e`](https://github.com/koel/koel/commit/a912f4e65a49ae1004483898f4fd2985da6c143f) fix: song controls disappear during filtering ### 📊 Changes **9 files changed** (+32 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/__tests__/UnitTestCase.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/podcastFactory.ts` (+1 -1) 📝 `resources/assets/js/components/screens/PlaylistScreen.vue` (+5 -0) 📝 `resources/assets/js/components/song/song-list/SongList.spec.ts` (+2 -2) 📝 `resources/assets/js/components/song/song-list/SongList.vue` (+2 -2) 📝 `resources/assets/js/components/song/song-list/SongListControls.spec.ts` (+2 -1) 📝 `resources/assets/js/components/song/song-list/SongListControls.vue` (+6 -5) 📝 `resources/assets/js/composables/useSongList.ts` (+10 -3) 📝 `resources/assets/js/symbols.ts` (+2 -1) </details> ### 📄 Description Song controls disappear if the filter returns an empty result set, since we are relying on the number of songs returned. Fixing by relying on the number of original songs before filtering instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:46 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:51 +03:00

[PR #1921] [MERGED] feat: set album release year during scan #1953

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1921

No description provided.

Rows
Columns