[PR #1855] [MERGED] refactor: remove barrel files #1912

New issue

Closed

opened 2026-02-26 03:32:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1855
Author: @phanan
Created: 10/17/2024
Status: ✅ Merged
Merged: 10/17/2024
Merged by: @phanan

Base: master ← Head: no-barrel

📝 Commits (1)

ab7bd32 refactor: remove barrel files

📊 Changes

344 files changed (+1280 additions, -983 deletions)

View changed files

📝 resources/assets/js/App.vue (+3 -3)
📝 resources/assets/js/__tests__/UnitTestCase.ts (+8 -7)
📝 resources/assets/js/__tests__/factory/genreFactory.ts (+1 -1)
📝 resources/assets/js/__tests__/factory/songFactory.ts (+1 -1)
📝 resources/assets/js/__tests__/stubs.ts (+1 -1)
📝 resources/assets/js/app.ts (+7 -3)
📝 resources/assets/js/components/album/AlbumCard.spec.ts (+5 -3)
📝 resources/assets/js/components/album/AlbumCard.vue (+9 -4)
📝 resources/assets/js/components/album/AlbumContextMenu.spec.ts (+5 -3)
📝 resources/assets/js/components/album/AlbumContextMenu.vue (+9 -4)
📝 resources/assets/js/components/album/AlbumInfo.spec.ts (+2 -2)
📝 resources/assets/js/components/album/AlbumInfo.vue (+2 -2)
📝 resources/assets/js/components/album/AlbumTrackList.spec.ts (+1 -1)
📝 resources/assets/js/components/album/AlbumTrackList.vue (+1 -1)
📝 resources/assets/js/components/album/AlbumTrackListItem.spec.ts (+3 -3)
📝 resources/assets/js/components/album/AlbumTrackListItem.vue (+6 -4)
📝 resources/assets/js/components/artist/ArtistCard.spec.ts (+5 -3)
📝 resources/assets/js/components/artist/ArtistCard.vue (+8 -4)
📝 resources/assets/js/components/artist/ArtistContextMenu.spec.ts (+6 -4)
📝 resources/assets/js/components/artist/ArtistContextMenu.vue (+8 -4)

...and 80 more files

📄 Description

Eliminating barrel files to avoid some circular dependencies.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1855 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/17/2024 **Status:** ✅ Merged **Merged:** 10/17/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `no-barrel` --- ### 📝 Commits (1) - [`ab7bd32`](https://github.com/koel/koel/commit/ab7bd321af0742c1afe06145184f510ae57d3a75) refactor: remove barrel files ### 📊 Changes **344 files changed** (+1280 additions, -983 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/App.vue` (+3 -3) 📝 `resources/assets/js/__tests__/UnitTestCase.ts` (+8 -7) 📝 `resources/assets/js/__tests__/factory/genreFactory.ts` (+1 -1) 📝 `resources/assets/js/__tests__/factory/songFactory.ts` (+1 -1) 📝 `resources/assets/js/__tests__/stubs.ts` (+1 -1) 📝 `resources/assets/js/app.ts` (+7 -3) 📝 `resources/assets/js/components/album/AlbumCard.spec.ts` (+5 -3) 📝 `resources/assets/js/components/album/AlbumCard.vue` (+9 -4) 📝 `resources/assets/js/components/album/AlbumContextMenu.spec.ts` (+5 -3) 📝 `resources/assets/js/components/album/AlbumContextMenu.vue` (+9 -4) 📝 `resources/assets/js/components/album/AlbumInfo.spec.ts` (+2 -2) 📝 `resources/assets/js/components/album/AlbumInfo.vue` (+2 -2) 📝 `resources/assets/js/components/album/AlbumTrackList.spec.ts` (+1 -1) 📝 `resources/assets/js/components/album/AlbumTrackList.vue` (+1 -1) 📝 `resources/assets/js/components/album/AlbumTrackListItem.spec.ts` (+3 -3) 📝 `resources/assets/js/components/album/AlbumTrackListItem.vue` (+6 -4) 📝 `resources/assets/js/components/artist/ArtistCard.spec.ts` (+5 -3) 📝 `resources/assets/js/components/artist/ArtistCard.vue` (+8 -4) 📝 `resources/assets/js/components/artist/ArtistContextMenu.spec.ts` (+6 -4) 📝 `resources/assets/js/components/artist/ArtistContextMenu.vue` (+8 -4) _...and 80 more files_ </details> ### 📄 Description Eliminating barrel files to avoid some circular dependencies. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1912

No description provided.

Rows
Columns