starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-26 01:06:00 +03:00

[PR #1848] [CLOSED] Feature suggestion: Let users add a `begin_at_seconds` property to songs #1907

New issue

Closed

opened 2026-02-26 03:32:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1848
Author: @ShetlandJ
Created: 10/13/2024
Status: ❌ Closed

Base: master ← Head: 1846-start-song-at

📝 Commits (9)

c74e77b feat(track start): add migration
1e8b9e1 feat(track start): add property & cast to model
dd2d0f3 feat(track start): add to testing model
22c3dbf feat(track start): update types model in preparation for updates
7a26212 feat(track start): add to song update data model
4f51bae feat(track start): update backend data model
cfa6159 feat(track start): fix property typo 😵
cba4915 feat(track start): add property to Song resource
c645680 feat(track start): round off last few bits

📊 Changes

10 files changed (+63 additions, -3 deletions)

View changed files

📝 app/Http/Resources/SongResource.php (+2 -0)
📝 app/Models/Song.php (+2 -0)
📝 app/Services/SongService.php (+2 -0)
📝 app/Values/SongUpdateData.php (+6 -1)
📝 database/factories/SongFactory.php (+1 -0)
➕ database/migrations/2024_10_12_122026_alter_songs_table_add_begin_at_seconds_column.php (+21 -0)
📝 resources/assets/js/components/song/EditSongForm.vue (+23 -1)
📝 resources/assets/js/components/song/SongList.vue (+3 -1)
📝 resources/assets/js/stores/songStore.ts (+1 -0)
📝 resources/assets/js/types.d.ts (+2 -0)

📄 Description

Closes #1846

This is a bit of a niche vanity addition that I often wish Spotify had. I have a playlist for when I'm jogging, and some songs that are on it that get my hyped up have very long intros with dead air because that's just how the artist wanted it I guess. I attach two such example in the issue. With this feature (might be a good case for a pro feature BTW, don't mind either way), I could curate my tracks even more to cut out bits from the intro of songs that kill my energy when I'm running.

Maintainers: Please close/disregard if not interested/applicable. Enjoying just playing about and won't take it personally if you say no to this feature.

Working example:

https://github.com/user-attachments/assets/4a6f63be-4901-4718-81be-07365997fa30

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1848 **Author:** [@ShetlandJ](https://github.com/ShetlandJ) **Created:** 10/13/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `1846-start-song-at` --- ### 📝 Commits (9) - [`c74e77b`](https://github.com/koel/koel/commit/c74e77bcda81f50ad0eac6d28f30d943e19df810) feat(track start): add migration - [`1e8b9e1`](https://github.com/koel/koel/commit/1e8b9e1ae96e6ebe5de6e4ac13acdf7b7663c03e) feat(track start): add property & cast to model - [`dd2d0f3`](https://github.com/koel/koel/commit/dd2d0f3316b18d887eafeb4978f10ecc81d712e1) feat(track start): add to testing model - [`22c3dbf`](https://github.com/koel/koel/commit/22c3dbf01ce0b98acd824d6e743d8252fd44bf12) feat(track start): update types model in preparation for updates - [`7a26212`](https://github.com/koel/koel/commit/7a26212dcee7e1fccf5c4e5e28f2dcff58499da6) feat(track start): add to song update data model - [`4f51bae`](https://github.com/koel/koel/commit/4f51bae988ccc06e8009f5b2c8b5a7beb17ec846) feat(track start): update backend data model - [`cfa6159`](https://github.com/koel/koel/commit/cfa615952c31f15c7c33860a80a30651c01a7f0d) feat(track start): fix property typo :dizzy_face: - [`cba4915`](https://github.com/koel/koel/commit/cba4915b985ffbdb5c93c4f7fe01e06ce535cfa5) feat(track start): add property to Song resource - [`c645680`](https://github.com/koel/koel/commit/c6456801107c741aa03de5c02f0f70f3cbe771b7) feat(track start): round off last few bits ### 📊 Changes **10 files changed** (+63 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Resources/SongResource.php` (+2 -0) 📝 `app/Models/Song.php` (+2 -0) 📝 `app/Services/SongService.php` (+2 -0) 📝 `app/Values/SongUpdateData.php` (+6 -1) 📝 `database/factories/SongFactory.php` (+1 -0) ➕ `database/migrations/2024_10_12_122026_alter_songs_table_add_begin_at_seconds_column.php` (+21 -0) 📝 `resources/assets/js/components/song/EditSongForm.vue` (+23 -1) 📝 `resources/assets/js/components/song/SongList.vue` (+3 -1) 📝 `resources/assets/js/stores/songStore.ts` (+1 -0) 📝 `resources/assets/js/types.d.ts` (+2 -0) </details> ### 📄 Description Closes #1846 This is a bit of a niche vanity addition that I often wish Spotify had. I have a playlist for when I'm jogging, and some songs that are on it that get my hyped up have very long intros with dead air because that's just how the artist wanted it I guess. I attach two such example in the issue. With this feature (might be a good case for a pro feature BTW, don't mind either way), I could curate my tracks even more to cut out bits from the intro of songs that kill my energy when I'm running. Maintainers: Please close/disregard if not interested/applicable. Enjoying just playing about and won't take it personally if you say no to this feature. Working example: https://github.com/user-attachments/assets/4a6f63be-4901-4718-81be-07365997fa30 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:43 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:50 +03:00

[PR #1908] [MERGED] fix: group by issue in Postgres (closes #1907) #1943

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1907

No description provided.

Rows
Columns

[PR #1848] [CLOSED] Feature suggestion: Let users add a begin_at_seconds property to songs #1907

📋 Pull Request Information

📝 Commits (9)

📊 Changes

📄 Description

[PR #1848] [CLOSED] Feature suggestion: Let users add a `begin_at_seconds` property to songs #1907