[PR #1850] [MERGED] feat: use a better ESLint setup #1906

New issue

Closed

opened 2026-02-26 03:32:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1850
Author: @phanan
Created: 10/13/2024
Status: ✅ Merged
Merged: 10/13/2024
Merged by: @phanan

Base: master ← Head: lint

📝 Commits (1)

4add346 fix: use a better ESLint setup

📊 Changes

384 files changed (+4792 additions, -3403 deletions)

View changed files

➖ .eslintrc (+0 -52)
➕ .vscode/settings.json (+49 -0)
➕ eslint.config.js (+31 -0)
📝 package.json (+7 -12)
📝 resources/assets/js/__tests__/UnitTestCase.ts (+19 -14)
📝 resources/assets/js/__tests__/factory/albumFactory.ts (+4 -4)
📝 resources/assets/js/__tests__/factory/albumInfoFactory.ts (+3 -3)
📝 resources/assets/js/__tests__/factory/albumTrackFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/artistFactory.ts (+5 -5)
📝 resources/assets/js/__tests__/factory/artistInfoFactory.ts (+3 -3)
📝 resources/assets/js/__tests__/factory/episodeFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/genreFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/index.ts (+21 -20)
📝 resources/assets/js/__tests__/factory/interactionFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/playlistCollaboratorFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/playlistFactory.ts (+5 -5)
📝 resources/assets/js/__tests__/factory/playlistFolderFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/podcastFactory.ts (+3 -3)
📝 resources/assets/js/__tests__/factory/smartPlaylistRuleFactory.ts (+2 -2)
📝 resources/assets/js/__tests__/factory/smartPlaylistRuleGroupFactory.ts (+2 -2)

...and 80 more files

📄 Description

Turns out the ESLint config and command have been dead for a while… This PR fixes the issue by using a better setup and applying all the fixes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1850 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/13/2024 **Status:** ✅ Merged **Merged:** 10/13/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `lint` --- ### 📝 Commits (1) - [`4add346`](https://github.com/koel/koel/commit/4add3461cc1621248565c6a275cb096c8f6fd445) fix: use a better ESLint setup ### 📊 Changes **384 files changed** (+4792 additions, -3403 deletions) <details> <summary>View changed files</summary> ➖ `.eslintrc` (+0 -52) ➕ `.vscode/settings.json` (+49 -0) ➕ `eslint.config.js` (+31 -0) 📝 `package.json` (+7 -12) 📝 `resources/assets/js/__tests__/UnitTestCase.ts` (+19 -14) 📝 `resources/assets/js/__tests__/factory/albumFactory.ts` (+4 -4) 📝 `resources/assets/js/__tests__/factory/albumInfoFactory.ts` (+3 -3) 📝 `resources/assets/js/__tests__/factory/albumTrackFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/artistFactory.ts` (+5 -5) 📝 `resources/assets/js/__tests__/factory/artistInfoFactory.ts` (+3 -3) 📝 `resources/assets/js/__tests__/factory/episodeFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/genreFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/index.ts` (+21 -20) 📝 `resources/assets/js/__tests__/factory/interactionFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/playlistCollaboratorFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/playlistFactory.ts` (+5 -5) 📝 `resources/assets/js/__tests__/factory/playlistFolderFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/podcastFactory.ts` (+3 -3) 📝 `resources/assets/js/__tests__/factory/smartPlaylistRuleFactory.ts` (+2 -2) 📝 `resources/assets/js/__tests__/factory/smartPlaylistRuleGroupFactory.ts` (+2 -2) _...and 80 more files_ </details> ### 📄 Description Turns out the ESLint config and command have been dead for a while… This PR fixes the issue by using a better setup and applying all the fixes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:43 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1906

No description provided.

Rows
Columns