[PR #1845] [MERGED] feat: Implement disc numbers when viewing an album #1904

New issue

Closed

opened 2026-02-26 03:32:43 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1845
Author: @ShetlandJ
Created: 10/11/2024
Status: ✅ Merged
Merged: 10/14/2024
Merged by: @phanan

Base: master ← Head: 1505-disc-support

📝 Commits (10+)

ed00a41 feat(disc numbers): initial implementation of disc numbers
f598f41 feat(disc numbers): tidy up + sorting logic
d098104 feat(disc numbers): calculate item pixel height
adf7741 feat(disc numbers): only in album context
2a54732 feat(disc numbers): clean up
16b657a feat(disc numbers): update tests and disc number declaration
19528a3 feat(disc numbers): final fixes
5b2b33c Merge branch 'master' into 1505-disc-support
9d4bcb0 feat(disc numbers): remove semi colons
29eaba7 Merge branch '1505-disc-support' of github.com:ShetlandJ/koel into 1505-disc-support

📊 Changes

5 files changed (+111 additions, -45 deletions)

View changed files

📝 resources/assets/js/components/song/SongList.vue (+46 -1)
📝 resources/assets/js/components/song/SongListItem.spec.ts (+13 -1)
📝 resources/assets/js/components/song/SongListItem.vue (+46 -35)
📝 resources/assets/js/components/song/__snapshots__/SongListItem.spec.ts.snap (+6 -3)
📝 yarn.lock (+0 -5)

📄 Description

Closes #1505

This will only work on the album view when sorted by tracklist. I would happily take CSS improvements/suggestions to the presentation of the "disc x" text too!

https://github.com/user-attachments/assets/e762c2cb-103a-48e3-8836-8ab094ad5252

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1845 **Author:** [@ShetlandJ](https://github.com/ShetlandJ) **Created:** 10/11/2024 **Status:** ✅ Merged **Merged:** 10/14/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `1505-disc-support` --- ### 📝 Commits (10+) - [`ed00a41`](https://github.com/koel/koel/commit/ed00a41b0aa0b1d16365558d3545d8a72571cd77) feat(disc numbers): initial implementation of disc numbers - [`f598f41`](https://github.com/koel/koel/commit/f598f41360ae2e5bb1889ab6dbab719a6a44cb0d) feat(disc numbers): tidy up + sorting logic - [`d098104`](https://github.com/koel/koel/commit/d09810494817567c3b75915b14283d94dc20f8b5) feat(disc numbers): calculate item pixel height - [`adf7741`](https://github.com/koel/koel/commit/adf7741e0629d2433896bc889e130f41a6b44f38) feat(disc numbers): only in album context - [`2a54732`](https://github.com/koel/koel/commit/2a5473204f2e45c1b11a2ce7f7792ed921d270e0) feat(disc numbers): clean up - [`16b657a`](https://github.com/koel/koel/commit/16b657a09eb3ca6a362cd6404d712b718130e681) feat(disc numbers): update tests and disc number declaration - [`19528a3`](https://github.com/koel/koel/commit/19528a354b892df401e8e5ac0940d500759b3f0c) feat(disc numbers): final fixes - [`5b2b33c`](https://github.com/koel/koel/commit/5b2b33c6fa671d36e9f753757d154dc44c3d3148) Merge branch 'master' into 1505-disc-support - [`9d4bcb0`](https://github.com/koel/koel/commit/9d4bcb0e3d2067a8dbf65ee345451b7fb574c15b) feat(disc numbers): remove semi colons - [`29eaba7`](https://github.com/koel/koel/commit/29eaba710ee33647c693e90edbae0ac210e22945) Merge branch '1505-disc-support' of github.com:ShetlandJ/koel into 1505-disc-support ### 📊 Changes **5 files changed** (+111 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/song/SongList.vue` (+46 -1) 📝 `resources/assets/js/components/song/SongListItem.spec.ts` (+13 -1) 📝 `resources/assets/js/components/song/SongListItem.vue` (+46 -35) 📝 `resources/assets/js/components/song/__snapshots__/SongListItem.spec.ts.snap` (+6 -3) 📝 `yarn.lock` (+0 -5) </details> ### 📄 Description Closes #1505 - This will only work on the album view when sorted by tracklist. I would happily take CSS improvements/suggestions to the presentation of the "disc x" text too! https://github.com/user-attachments/assets/e762c2cb-103a-48e3-8836-8ab094ad5252 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:43 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1904

No description provided.

Rows
Columns