mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[PR #1844] [CLOSED] feat(multi threaded): attempt job approach for koel:scan #1903
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1903
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1844
Author: @ShetlandJ
Created: 10/10/2024
Status: ❌ Closed
Base:
master← Head:1711-multi-threaded-attempt📝 Commits (5)
acce313feat(multi threaded): attempt job approach forkoel:scan8950a06feat(jobs): remove loggerdfa8c13feat(jobs): add removed line back inb7422f8feat(jobs): more changes?3a2f526feat(jobs): return results📊 Changes
2 files changed (+78 additions, -2 deletions)
View changed files
➕
app/Jobs/ScanSongsJob.php(+37 -0)📝
app/Services/MediaScanner.php(+41 -2)📄 Description
Begins to address @romner-set's request in #1711.
I can't get redis to run for this repo for some reason 🤔 , so I've only really validated it with
sync. I'm also not sure on handling some of the events around it. I thought to make a draft to at least generate discussion.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.