[PR #1843] [CLOSED] feat(play count): add play count to song list #1901

New issue

Closed

opened 2026-02-26 03:32:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1843
Author: @ShetlandJ
Created: 10/8/2024
Status: ❌ Closed

Base: master ← Head: 1821-sort-by-plays

📝 Commits (10+)

fda0a54 feat(play count): add sort by play count
837a69e feat(song builder): add sorting for play counts
f593c5c feat(play count): add minimum width css
4e74722 feat(play count): add human-readable number formatter
e76e450 feat(play count): bring in and render the play count on the page
6114852 feat(play count): remove test-data-id
6920e0e feat(play count): hide on narrowed view
42d8ad2 feat(play count): add extra checking condition
e2c3e81 feat(play count): small tidy up
6bd89b8 feat(play count): update snapshot

📊 Changes

9 files changed (+76 additions, -5 deletions)

View changed files

📝 app/Builders/SongBuilder.php (+2 -0)
📝 resources/assets/js/components/song/SongList.vue (+17 -2)
📝 resources/assets/js/components/song/SongListItem.spec.ts (+1 -0)
📝 resources/assets/js/components/song/SongListItem.vue (+11 -0)
📝 resources/assets/js/components/song/SongListSorter.vue (+5 -0)
📝 resources/assets/js/components/song/__snapshots__/SongList.spec.ts.snap (+1 -1)
📝 resources/assets/js/types.d.ts (+1 -1)
📝 resources/assets/js/utils/helpers.spec.ts (+29 -1)
📝 resources/assets/js/utils/helpers.ts (+9 -0)

📄 Description

Closes #1821

Hello, this raised issue had no reply from @phanan or other maintainers so please feel free to close it if it is not in the feature plan. I thought that it was a good idea as many musicos like to track their play counts.

Here's a screenshot of what it looks like in action.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1843 **Author:** [@ShetlandJ](https://github.com/ShetlandJ) **Created:** 10/8/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `1821-sort-by-plays` --- ### 📝 Commits (10+) - [`fda0a54`](https://github.com/koel/koel/commit/fda0a54e11c32ee616e7c74aeebe8eef958b2743) feat(play count): add sort by play count - [`837a69e`](https://github.com/koel/koel/commit/837a69ed04a7efcb9e06b04ef150f3b020c2cc57) feat(song builder): add sorting for play counts - [`f593c5c`](https://github.com/koel/koel/commit/f593c5cb9a200c41167606d42573024ea56f1d25) feat(play count): add minimum width css - [`4e74722`](https://github.com/koel/koel/commit/4e74722f20fd470d735d5bfb1ce4c6995cf66a0c) feat(play count): add human-readable number formatter - [`e76e450`](https://github.com/koel/koel/commit/e76e450ac57c395e6942493a282646ef9b8c5e3d) feat(play count): bring in and render the play count on the page - [`6114852`](https://github.com/koel/koel/commit/61148529f1b3d0d44c4fc1e81183c57e39cf11e6) feat(play count): remove test-data-id - [`6920e0e`](https://github.com/koel/koel/commit/6920e0e11f10b2b6046cc1bf999484937908f400) feat(play count): hide on narrowed view - [`42d8ad2`](https://github.com/koel/koel/commit/42d8ad2f4af07787bdcc720814940746eb0cb7ae) feat(play count): add extra checking condition - [`e2c3e81`](https://github.com/koel/koel/commit/e2c3e8179af765f29fa9d1553f49394cf6f35f20) feat(play count): small tidy up - [`6bd89b8`](https://github.com/koel/koel/commit/6bd89b8256422632eee522b853f0fd276df80641) feat(play count): update snapshot ### 📊 Changes **9 files changed** (+76 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `app/Builders/SongBuilder.php` (+2 -0) 📝 `resources/assets/js/components/song/SongList.vue` (+17 -2) 📝 `resources/assets/js/components/song/SongListItem.spec.ts` (+1 -0) 📝 `resources/assets/js/components/song/SongListItem.vue` (+11 -0) 📝 `resources/assets/js/components/song/SongListSorter.vue` (+5 -0) 📝 `resources/assets/js/components/song/__snapshots__/SongList.spec.ts.snap` (+1 -1) 📝 `resources/assets/js/types.d.ts` (+1 -1) 📝 `resources/assets/js/utils/helpers.spec.ts` (+29 -1) 📝 `resources/assets/js/utils/helpers.ts` (+9 -0) </details> ### 📄 Description Closes #1821 Hello, this raised issue had no reply from @phanan or other maintainers so please feel free to close it if it is not in the feature plan. I thought that it was a good idea as many musicos like to track their play counts. Here's a screenshot of what it looks like in action. <img width="1044" alt="Screenshot 2024-10-07 at 21 06 24" src="https://github.com/user-attachments/assets/43499f7a-06e2-40d8-b49d-952b2ee553e6"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:42 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1901

No description provided.

Rows
Columns