[PR #1839] [MERGED] chore: cache model attributes #1898

New issue

Closed

opened 2026-02-26 03:32:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1839
Author: @phanan
Created: 10/5/2024
Status: ✅ Merged
Merged: 10/6/2024
Merged by: @phanan

Base: master ← Head: attr-should-cache

📝 Commits (1)

577ec1c chore: cache model attributes

📊 Changes

7 files changed (+38 additions, -31 deletions)

View changed files

📝 app/Models/Album.php (+10 -7)
📝 app/Models/Artist.php (+6 -4)
📝 app/Models/License.php (+2 -2)
📝 app/Models/Playlist.php (+6 -6)
📝 app/Models/PlaylistCollaborationToken.php (+1 -1)
📝 app/Models/Song.php (+7 -7)
📝 app/Models/User.php (+6 -4)

📄 Description

Use shouldCache() on (applicable) attributes for some micro improvements.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1839 **Author:** [@phanan](https://github.com/phanan) **Created:** 10/5/2024 **Status:** ✅ Merged **Merged:** 10/6/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `attr-should-cache` --- ### 📝 Commits (1) - [`577ec1c`](https://github.com/koel/koel/commit/577ec1cf87ed59160fd388baa7c1fcd38a37ebdd) chore: cache model attributes ### 📊 Changes **7 files changed** (+38 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `app/Models/Album.php` (+10 -7) 📝 `app/Models/Artist.php` (+6 -4) 📝 `app/Models/License.php` (+2 -2) 📝 `app/Models/Playlist.php` (+6 -6) 📝 `app/Models/PlaylistCollaborationToken.php` (+1 -1) 📝 `app/Models/Song.php` (+7 -7) 📝 `app/Models/User.php` (+6 -4) </details> ### 📄 Description Use `shouldCache()` on (applicable) attributes for some micro improvements. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:42 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:49 +03:00

[PR #1898] [CLOSED] fix: Keep the folder structure on gitignore #1942

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1898

No description provided.

Rows
Columns