[PR #1833] [MERGED] feat: replace attempt() with built-in rescue() #1893

New issue

Closed

opened 2026-02-26 03:32:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1833
Author: @phanan
Created: 9/30/2024
Status: ✅ Merged
Merged: 9/30/2024
Merged by: @phanan

Base: master ← Head: attempt-to-rescue

📝 Commits (3)

6a89ef8 feat(build): upgrade actions/upload-artifact to v4
4e58019 feat: replace attempt() with built-in rescue()
0184bea Merge branch 'master' into attempt-to-rescue

📊 Changes

20 files changed (+43 additions, -65 deletions)

View changed files

📝 app/Casts/SmartPlaylistRulesCast.php (+3 -5)
📝 app/Helpers.php (+5 -26)
📝 app/Http/Controllers/API/AuthController.php (+1 -1)
📝 app/Http/Integrations/Spotify/SpotifyClient.php (+1 -1)
📝 app/Listeners/WriteSyncLog.php (+1 -1)
📝 app/Models/SongZipArchive.php (+1 -1)
📝 app/Observers/AlbumObserver.php (+1 -1)
📝 app/Repositories/Repository.php (+1 -1)
📝 app/Rules/ImageData.php (+2 -2)
📝 app/Rules/SupportedAudioFile.php (+2 -2)
📝 app/Rules/ValidSmartPlaylistRulePayload.php (+1 -1)
📝 app/Services/ApplicationInformationService.php (+1 -1)
📝 app/Services/FileScanner.php (+3 -3)
📝 app/Services/ITunesService.php (+1 -1)
📝 app/Services/LastfmService.php (+5 -5)
📝 app/Services/MediaInformationService.php (+2 -2)
📝 app/Services/MediaMetadataService.php (+3 -3)
📝 database/migrations/2021_06_04_153259_convert_user_preferences_from_array_to_json.php (+2 -2)
📝 database/migrations/2022_08_04_092531_drop_contributing_artist_id.php (+2 -2)
📝 tests/Unit/Rules/ValidSmartPlaylistRulePayloadTest.php (+5 -4)

📄 Description

Replace the custom attempt() with Laravel's built-in rescue()

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1833 **Author:** [@phanan](https://github.com/phanan) **Created:** 9/30/2024 **Status:** ✅ Merged **Merged:** 9/30/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `attempt-to-rescue` --- ### 📝 Commits (3) - [`6a89ef8`](https://github.com/koel/koel/commit/6a89ef8257bc218599719fd3818aae4647fb4ef1) feat(build): upgrade actions/upload-artifact to v4 - [`4e58019`](https://github.com/koel/koel/commit/4e58019c11d460c7999c02b86cb8960befdaf634) feat: replace attempt() with built-in rescue() - [`0184bea`](https://github.com/koel/koel/commit/0184beaa12a600b7a2235bc08c5a44898faad4de) Merge branch 'master' into attempt-to-rescue ### 📊 Changes **20 files changed** (+43 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `app/Casts/SmartPlaylistRulesCast.php` (+3 -5) 📝 `app/Helpers.php` (+5 -26) 📝 `app/Http/Controllers/API/AuthController.php` (+1 -1) 📝 `app/Http/Integrations/Spotify/SpotifyClient.php` (+1 -1) 📝 `app/Listeners/WriteSyncLog.php` (+1 -1) 📝 `app/Models/SongZipArchive.php` (+1 -1) 📝 `app/Observers/AlbumObserver.php` (+1 -1) 📝 `app/Repositories/Repository.php` (+1 -1) 📝 `app/Rules/ImageData.php` (+2 -2) 📝 `app/Rules/SupportedAudioFile.php` (+2 -2) 📝 `app/Rules/ValidSmartPlaylistRulePayload.php` (+1 -1) 📝 `app/Services/ApplicationInformationService.php` (+1 -1) 📝 `app/Services/FileScanner.php` (+3 -3) 📝 `app/Services/ITunesService.php` (+1 -1) 📝 `app/Services/LastfmService.php` (+5 -5) 📝 `app/Services/MediaInformationService.php` (+2 -2) 📝 `app/Services/MediaMetadataService.php` (+3 -3) 📝 `database/migrations/2021_06_04_153259_convert_user_preferences_from_array_to_json.php` (+2 -2) 📝 `database/migrations/2022_08_04_092531_drop_contributing_artist_id.php` (+2 -2) 📝 `tests/Unit/Rules/ValidSmartPlaylistRulePayloadTest.php` (+5 -4) </details> ### 📄 Description Replace the custom `attempt()` with Laravel's built-in `rescue()` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:41 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:49 +03:00

[PR #1893] [CLOSED] build(deps): bump nesbot/carbon from 2.72.3 to 2.72.6 #1938

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1893

No description provided.

Rows
Columns