[PR #1815] [MERGED] fix: display defaultCover when processing empty cover image #1882

New issue

Closed

opened 2026-02-26 03:32:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1815
Author: @PBK-B
Created: 8/29/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @phanan

Base: master ← Head: fix_ui_cover

📝 Commits (4)

0d7723c fix(ui): display defaultCover when processing empty cover image
5d5e116 fix(ui): load default avatar when avatar loading fails
2680555 fix: avoid the default avatar to modify the form value
ad4adbf chore: use @error syntax

📊 Changes

3 files changed (+8 additions, -5 deletions)

View changed files

📝 resources/assets/js/components/layout/app-footer/FooterSongInfo.vue (+1 -1)
📝 resources/assets/js/components/ui/__snapshots__/ProfileAvatar.spec.ts.snap (+1 -1)
📝 resources/assets/js/components/user/UserAvatar.vue (+6 -3)

📄 Description

display defaultCover when processing empty cover image
load default avatar when avatar loading fails, because the network in some places can't access www.gravatar.com, I added the default avatar to use logo.

@phanan TBR; thank you for your excellent work to bring us joy, If there is anything I can do for you, please let me know.

[Surprise Origin] lzc-app porting upstream code giveback plan

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1815 **Author:** [@PBK-B](https://github.com/PBK-B) **Created:** 8/29/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix_ui_cover` --- ### 📝 Commits (4) - [`0d7723c`](https://github.com/koel/koel/commit/0d7723cc1b53aa14e0e8bdf4e76b1ad58aca4d9a) fix(ui): display defaultCover when processing empty cover image - [`5d5e116`](https://github.com/koel/koel/commit/5d5e116e0a2c01b210bf7328e17676d84a193d9f) fix(ui): load default avatar when avatar loading fails - [`2680555`](https://github.com/koel/koel/commit/26805554d5bc5129243590f82d007e3352d884a1) fix: avoid the default avatar to modify the form value - [`ad4adbf`](https://github.com/koel/koel/commit/ad4adbf5ccce926ff9cc634642b128224a15dc01) chore: use @error syntax ### 📊 Changes **3 files changed** (+8 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/components/layout/app-footer/FooterSongInfo.vue` (+1 -1) 📝 `resources/assets/js/components/ui/__snapshots__/ProfileAvatar.spec.ts.snap` (+1 -1) 📝 `resources/assets/js/components/user/UserAvatar.vue` (+6 -3) </details> ### 📄 Description - display defaultCover when processing empty cover image - load default avatar when avatar loading fails, because the network in some places can't access www.gravatar.com, I added the default avatar to use logo. @phanan TBR; thank you for your excellent work to bring us joy, If there is anything I can do for you, please let me know. **[Surprise Origin] [lzc-app](https://lazycat.cloud/appstore/%2Fshop%2Fdetail%2Fcloud.lazycat.app.koel) porting upstream code giveback plan** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:39 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1882

No description provided.

Rows
Columns