starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-26 09:15:59 +03:00

[PR #1697] [CLOSED] [WIP] Update Koel to Cypress v12 #1847

New issue

Closed

opened 2026-02-26 03:32:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1697
Author: @JoshSalway
Created: 7/7/2023
Status: ❌ Closed

Base: master ← Head: refactor/cypress-12

📝 Commits (1)

4a6aa77 WIP

📊 Changes

30 files changed (+215 additions, -56 deletions)

View changed files

➖ cypress.json (+0 -11)
📝 cypress/e2e/about.spec.ts (+0 -0)
📝 cypress/e2e/albums.spec.ts (+0 -0)
📝 cypress/e2e/artists.spec.ts (+0 -0)
📝 cypress/e2e/authentication.spec.ts (+0 -0)
📝 cypress/e2e/extra-panel.spec.ts (+0 -0)
📝 cypress/e2e/favorites.spec.ts (+0 -0)
📝 cypress/e2e/footer-pane.spec.ts (+0 -0)
📝 cypress/e2e/home.spec.ts (+0 -0)
📝 cypress/e2e/layout.spec.ts (+0 -0)
📝 cypress/e2e/other-controls.spec.ts (+0 -0)
📝 cypress/e2e/playlists.spec.ts (+0 -0)
📝 cypress/e2e/profile.spec.ts (+0 -0)
📝 cypress/e2e/queuing.spec.ts (+0 -0)
📝 cypress/e2e/searching.spec.ts (+0 -0)
📝 cypress/e2e/settings.spec.ts (+0 -0)
📝 cypress/e2e/shortcut-keys.spec.ts (+0 -0)
📝 cypress/e2e/sidebar.spec.ts (+0 -0)
📝 cypress/e2e/song-context-menu.spec.ts (+0 -0)
📝 cypress/e2e/song-editing.spec.ts (+0 -0)

...and 10 more files

📄 Description

Description

This pull request is a work-in-progress (WIP) to update Koel to use Cypress v12. The purpose of this update is to take advantage of new features and improvements introduced in the latest version of Cypress.

Changes Made

Upgraded Cypress to version 12.
Verified compatibility with project dependencies, including @testing-library/cypress.
Cleared the Cypress cache to ensure the latest dependencies are used.
Reinstalled Cypress dependencies by removing the node_modules directory and running yarn install.

Testing

Ran the existing tests using the updated Cypress version to ensure basic functionality. It failed at the login step and could not get any further.

Note to Reviewers

This pull request is a work-in-progress and is being shared for initial feedback and collaboration.

Please note that this pull request is not ready for merging yet and should be considered as a draft until all issues are resolved.

Issue:
https://github.com/koel/koel/issues/1696

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1697 **Author:** [@JoshSalway](https://github.com/JoshSalway) **Created:** 7/7/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `refactor/cypress-12` --- ### 📝 Commits (1) - [`4a6aa77`](https://github.com/koel/koel/commit/4a6aa77a4fd8c0c55ec0cb71acc3917eefed1848) WIP ### 📊 Changes **30 files changed** (+215 additions, -56 deletions) <details> <summary>View changed files</summary> ➖ `cypress.json` (+0 -11) 📝 `cypress/e2e/about.spec.ts` (+0 -0) 📝 `cypress/e2e/albums.spec.ts` (+0 -0) 📝 `cypress/e2e/artists.spec.ts` (+0 -0) 📝 `cypress/e2e/authentication.spec.ts` (+0 -0) 📝 `cypress/e2e/extra-panel.spec.ts` (+0 -0) 📝 `cypress/e2e/favorites.spec.ts` (+0 -0) 📝 `cypress/e2e/footer-pane.spec.ts` (+0 -0) 📝 `cypress/e2e/home.spec.ts` (+0 -0) 📝 `cypress/e2e/layout.spec.ts` (+0 -0) 📝 `cypress/e2e/other-controls.spec.ts` (+0 -0) 📝 `cypress/e2e/playlists.spec.ts` (+0 -0) 📝 `cypress/e2e/profile.spec.ts` (+0 -0) 📝 `cypress/e2e/queuing.spec.ts` (+0 -0) 📝 `cypress/e2e/searching.spec.ts` (+0 -0) 📝 `cypress/e2e/settings.spec.ts` (+0 -0) 📝 `cypress/e2e/shortcut-keys.spec.ts` (+0 -0) 📝 `cypress/e2e/sidebar.spec.ts` (+0 -0) 📝 `cypress/e2e/song-context-menu.spec.ts` (+0 -0) 📝 `cypress/e2e/song-editing.spec.ts` (+0 -0) _...and 10 more files_ </details> ### 📄 Description ## Description This pull request is a work-in-progress (WIP) to update Koel to use Cypress v12. The purpose of this update is to take advantage of new features and improvements introduced in the latest version of Cypress. ## Changes Made - Upgraded Cypress to version 12. - Verified compatibility with project dependencies, including `@testing-library/cypress`. - Cleared the Cypress cache to ensure the latest dependencies are used. - Reinstalled Cypress dependencies by removing the `node_modules` directory and running `yarn install`. ## Testing - Ran the existing tests using the updated Cypress version to ensure basic functionality. It failed at the login step and could not get any further. ## Note to Reviewers This pull request is a work-in-progress and is being shared for initial feedback and collaboration. Please note that this pull request is not ready for merging yet and should be considered as a draft until all issues are resolved. Issue: https://github.com/koel/koel/issues/1696 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:31 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1847

No description provided.

Rows
Columns