[PR #1673] [CLOSED] Scrollbars are styled closer to the current themes colors. Due to lim… #1842

New issue

Closed

opened 2026-02-26 03:32:30 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:30 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1673
Author: @SketchNI
Created: 4/28/2023
Status: ❌ Closed

Base: master ← Head: themed-scrollbars

📝 Commits (2)

5f7a7c7 Scrollbars are styled closer to the current themes colors. Due to limitations in browser support for styling scrollbars (I'm looking at you, Firefox), these styles are pretty basic. Hopefully in future we'll be able to use gradients to better integrate the scrollbar into themes but this will do for now.
c8df3b0 Discard changes to resources/assets/js/themes.ts

📊 Changes

2 files changed (+27 additions, -1 deletions)

View changed files

📝 resources/assets/js/types.d.ts (+2 -0)
📝 resources/assets/sass/partials/_shared.scss (+25 -1)

📄 Description

…itations in browser support for styling scrollbars (I'm looking at you, Firefox), these styles are pretty basic. Hopefully in future we'll be able to use gradients to better integrate the scrollbar into themes but this will do for now.

I think either eslint (or phpstorms built-in eslint rules) completely munched the single-quotes into double-quotes which is why this PR is larger than I intended. I can reverse this if you want.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1673 **Author:** [@SketchNI](https://github.com/SketchNI) **Created:** 4/28/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `themed-scrollbars` --- ### 📝 Commits (2) - [`5f7a7c7`](https://github.com/koel/koel/commit/5f7a7c7997fcd0cc1cf44910470c9dd3c1f9497f) Scrollbars are styled closer to the current themes colors. Due to limitations in browser support for styling scrollbars (I'm looking at you, Firefox), these styles are pretty basic. Hopefully in future we'll be able to use gradients to better integrate the scrollbar into themes but this will do for now. - [`c8df3b0`](https://github.com/koel/koel/commit/c8df3b05bf5e9939800d6019572c8961137b94ce) Discard changes to resources/assets/js/themes.ts ### 📊 Changes **2 files changed** (+27 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/types.d.ts` (+2 -0) 📝 `resources/assets/sass/partials/_shared.scss` (+25 -1) </details> ### 📄 Description …itations in browser support for styling scrollbars (I'm looking at you, Firefox), these styles are pretty basic. Hopefully in future we'll be able to use gradients to better integrate the scrollbar into themes but this will do for now. I think either eslint (or phpstorms built-in eslint rules) completely munched the single-quotes into double-quotes which is why this PR is larger than I intended. I can reverse this if you want. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:30 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:42 +03:00

[PR #1842] [MERGED] fix(editing songs): track number removed when editing multiple songs #1900

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1842

No description provided.

Rows
Columns