mirror of
https://github.com/koel/koel.git
synced 2026-04-26 01:06:00 +03:00
[PR #1660] [MERGED] feat: increase send_timeout in nginx config #1835
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1835
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1660
Author: @davidschlachter
Created: 2/19/2023
Status: ✅ Merged
Merged: 2/25/2023
Merged by: @phanan
Base:
master← Head:fix-nginx📝 Commits (1)
d9dd5cfIncrease send_timeout in nginx config📊 Changes
1 file changed (+2 additions, -0 deletions)
View changed files
📝
nginx.conf.example(+2 -0)📄 Description
This PR specifies a
send_timeoutin the examplenginxconfiguration.If the
koelclient has not finished buffering a song within the default client timeout (60s),nginxcloses the connection. This causes the song to either stop playing in a desktop browser, or skip to the beginning and endlessly repeat in the mobile app. By increasing the client timeout,nginxkeeps the connection open until buffering is done.c.f. https://www.davidschlachter.com/misc/koel-songs-skipping-stopping
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.