mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[PR #1607] [MERGED] fix: update multiple songs duplicate values #1808
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1808
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1607
Author: @phanan
Created: 11/29/2022
Status: ✅ Merged
Merged: 11/29/2022
Merged by: @phanan
Base:
master← Head:fix/update-songs📝 Commits (1)
a309ebffix: update multiple songs duplicate values📊 Changes
3 files changed (+59 additions, -11 deletions)
View changed files
📝
app/Services/SongService.php(+22 -7)📝
app/Values/SongUpdateData.php(+1 -1)📝
tests/Feature/SongTest.php(+36 -3)📄 Description
Fixing a bug where updating multiple songs will leak data from the first song to the next.
Also fixing a bug where user can't clear some values when editing only one song.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.