[PR #1607] [MERGED] fix: update multiple songs duplicate values #1808

Closed
opened 2026-02-26 03:32:23 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1607
Author: @phanan
Created: 11/29/2022
Status: Merged
Merged: 11/29/2022
Merged by: @phanan

Base: masterHead: fix/update-songs


📝 Commits (1)

  • a309ebf fix: update multiple songs duplicate values

📊 Changes

3 files changed (+59 additions, -11 deletions)

View changed files

📝 app/Services/SongService.php (+22 -7)
📝 app/Values/SongUpdateData.php (+1 -1)
📝 tests/Feature/SongTest.php (+36 -3)

📄 Description

Fixing a bug where updating multiple songs will leak data from the first song to the next.
Also fixing a bug where user can't clear some values when editing only one song.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1607 **Author:** [@phanan](https://github.com/phanan) **Created:** 11/29/2022 **Status:** ✅ Merged **Merged:** 11/29/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `fix/update-songs` --- ### 📝 Commits (1) - [`a309ebf`](https://github.com/koel/koel/commit/a309ebff04683da6e5d9e9ae8a369646c7ae0ff0) fix: update multiple songs duplicate values ### 📊 Changes **3 files changed** (+59 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `app/Services/SongService.php` (+22 -7) 📝 `app/Values/SongUpdateData.php` (+1 -1) 📝 `tests/Feature/SongTest.php` (+36 -3) </details> ### 📄 Description Fixing a bug where updating multiple songs will leak data from the first song to the next. Also fixing a bug where user can't clear some values when editing only one song. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:23 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1808
No description provided.