[PR #1597] [MERGED] feat: turn overlay functionalities into composable #1800

New issue

Closed

opened 2026-02-26 03:32:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1597
Author: @phanan
Created: 11/19/2022
Status: ✅ Merged
Merged: 11/19/2022
Merged by: @phanan

Base: master ← Head: feat/overlay-comp

📝 Commits (3)

867001d feat: turn overlay functionalities into composable
604ecc1 revert: c68b3186b
a11fb3b fix: broken tests

📊 Changes

20 files changed (+93 additions, -146 deletions)

View changed files

📝 resources/assets/js/App.vue (+6 -6)
📝 resources/assets/js/__tests__/UnitTestCase.ts (+8 -2)
📝 resources/assets/js/__tests__/stubs.ts (+6 -0)
📝 resources/assets/js/components/screens/SettingsScreen.vue (+3 -2)
📝 resources/assets/js/components/song/EditSongForm.spec.ts (+5 -0)
📝 resources/assets/js/components/song/SongContextMenu.spec.ts (+2 -0)
➖ resources/assets/js/components/ui/Overlay.spec.ts (+0 -48)
📝 resources/assets/js/components/ui/Overlay.vue (+2 -4)
➖ resources/assets/js/components/ui/__snapshots__/Overlay.spec.ts.snap (+0 -56)
📝 resources/assets/js/components/user/AddUserForm.spec.ts (+4 -0)
📝 resources/assets/js/components/user/EditUserForm.spec.ts (+4 -0)
📝 resources/assets/js/components/utils/GlobalEventListeners.ts (+10 -4)
📝 resources/assets/js/composables/index.ts (+1 -0)
📝 resources/assets/js/composables/useDialogBox.ts (+10 -6)
📝 resources/assets/js/composables/useMessageToaster.ts (+9 -5)
➕ resources/assets/js/composables/useOverlay.ts (+15 -0)
📝 resources/assets/js/composables/useRouter.ts (+5 -2)
📝 resources/assets/js/config/events.ts (+0 -2)
📝 resources/assets/js/symbols.ts (+2 -0)
📝 resources/assets/js/utils/common.ts (+1 -9)

📄 Description

Also rewriting the DialogBox, MessageToast, and Router composables so that the instances are reused (singletons) throughout the app. This makes testing possible again.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1597 **Author:** [@phanan](https://github.com/phanan) **Created:** 11/19/2022 **Status:** ✅ Merged **Merged:** 11/19/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/overlay-comp` --- ### 📝 Commits (3) - [`867001d`](https://github.com/koel/koel/commit/867001dbb22fc9b8e30d2b8694ceaabc8e0ce75e) feat: turn overlay functionalities into composable - [`604ecc1`](https://github.com/koel/koel/commit/604ecc149da60b090f2d5becbf4999a0567484f5) revert: c68b3186b - [`a11fb3b`](https://github.com/koel/koel/commit/a11fb3b0cb3aa86dc50c0ffa44e2b713dab06ca8) fix: broken tests ### 📊 Changes **20 files changed** (+93 additions, -146 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/App.vue` (+6 -6) 📝 `resources/assets/js/__tests__/UnitTestCase.ts` (+8 -2) 📝 `resources/assets/js/__tests__/stubs.ts` (+6 -0) 📝 `resources/assets/js/components/screens/SettingsScreen.vue` (+3 -2) 📝 `resources/assets/js/components/song/EditSongForm.spec.ts` (+5 -0) 📝 `resources/assets/js/components/song/SongContextMenu.spec.ts` (+2 -0) ➖ `resources/assets/js/components/ui/Overlay.spec.ts` (+0 -48) 📝 `resources/assets/js/components/ui/Overlay.vue` (+2 -4) ➖ `resources/assets/js/components/ui/__snapshots__/Overlay.spec.ts.snap` (+0 -56) 📝 `resources/assets/js/components/user/AddUserForm.spec.ts` (+4 -0) 📝 `resources/assets/js/components/user/EditUserForm.spec.ts` (+4 -0) 📝 `resources/assets/js/components/utils/GlobalEventListeners.ts` (+10 -4) 📝 `resources/assets/js/composables/index.ts` (+1 -0) 📝 `resources/assets/js/composables/useDialogBox.ts` (+10 -6) 📝 `resources/assets/js/composables/useMessageToaster.ts` (+9 -5) ➕ `resources/assets/js/composables/useOverlay.ts` (+15 -0) 📝 `resources/assets/js/composables/useRouter.ts` (+5 -2) 📝 `resources/assets/js/config/events.ts` (+0 -2) 📝 `resources/assets/js/symbols.ts` (+2 -0) 📝 `resources/assets/js/utils/common.ts` (+1 -9) </details> ### 📄 Description Also rewriting the DialogBox, MessageToast, and Router composables so that the instances are reused (singletons) throughout the app. This makes testing possible again. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:21 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1800

No description provided.

Rows
Columns