[PR #1595] [MERGED] feat: use composables for DialogBox, MessageToast, and Router #1799

New issue

Closed

opened 2026-02-26 03:32:21 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:21 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1595
Author: @phanan
Created: 11/18/2022
Status: ✅ Merged
Merged: 11/18/2022
Merged by: @phanan

Base: master ← Head: feat/dialog-toast-comp

📝 Commits (4)

246fff5 feat: use composables for DialogBox and MessageToast
bc5081c feat: use composables for Router
7583229 feat: merge useScreen into useRouter
c68b318 fix: broken tests

📊 Changes

59 files changed (+373 additions, -380 deletions)

View changed files

📝 resources/assets/js/App.vue (+5 -6)
📝 resources/assets/js/components/album/AlbumCard.vue (+4 -7)
📝 resources/assets/js/components/album/AlbumContextMenu.vue (+7 -8)
📝 resources/assets/js/components/album/AlbumInfo.vue (+5 -8)
📝 resources/assets/js/components/artist/ArtistCard.vue (+4 -6)
📝 resources/assets/js/components/artist/ArtistContextMenu.vue (+6 -7)
📝 resources/assets/js/components/artist/ArtistInfo.vue (+3 -6)
📝 resources/assets/js/components/layout/main-wrapper/MainContent.vue (+5 -5)
📝 resources/assets/js/components/layout/main-wrapper/Sidebar.vue (+4 -6)
📝 resources/assets/js/components/playlist/CreatePlaylistFolderForm.vue (+7 -7)
📝 resources/assets/js/components/playlist/CreatePlaylistForm.vue (+9 -9)
📝 resources/assets/js/components/playlist/EditPlaylistFolderForm.vue (+7 -6)
📝 resources/assets/js/components/playlist/EditPlaylistForm.vue (+7 -6)
📝 resources/assets/js/components/playlist/PlaylistFolderContextMenu.vue (+5 -7)
📝 resources/assets/js/components/playlist/PlaylistSidebarItem.vue (+4 -5)
📝 resources/assets/js/components/playlist/PlaylistSidebarList.vue (+1 -4)
📝 resources/assets/js/components/playlist/smart-playlist/CreateSmartPlaylistForm.vue (+10 -10)
📝 resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue (+7 -7)
📝 resources/assets/js/components/profile-preferences/ProfileForm.vue (+10 -9)
📝 resources/assets/js/components/screens/AlbumListScreen.vue (+2 -2)

...and 39 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1595 **Author:** [@phanan](https://github.com/phanan) **Created:** 11/18/2022 **Status:** ✅ Merged **Merged:** 11/18/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/dialog-toast-comp` --- ### 📝 Commits (4) - [`246fff5`](https://github.com/koel/koel/commit/246fff58d3de8d14f65c2cc7769c06590b39c511) feat: use composables for DialogBox and MessageToast - [`bc5081c`](https://github.com/koel/koel/commit/bc5081cd0f33cdbf12e7b214b9cb6bd9077be509) feat: use composables for Router - [`7583229`](https://github.com/koel/koel/commit/758322988a0247fc2654e9eeba5253a98f07ba87) feat: merge useScreen into useRouter - [`c68b318`](https://github.com/koel/koel/commit/c68b3186b85cab84490b497e07a790e20315c2b9) fix: broken tests ### 📊 Changes **59 files changed** (+373 additions, -380 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/App.vue` (+5 -6) 📝 `resources/assets/js/components/album/AlbumCard.vue` (+4 -7) 📝 `resources/assets/js/components/album/AlbumContextMenu.vue` (+7 -8) 📝 `resources/assets/js/components/album/AlbumInfo.vue` (+5 -8) 📝 `resources/assets/js/components/artist/ArtistCard.vue` (+4 -6) 📝 `resources/assets/js/components/artist/ArtistContextMenu.vue` (+6 -7) 📝 `resources/assets/js/components/artist/ArtistInfo.vue` (+3 -6) 📝 `resources/assets/js/components/layout/main-wrapper/MainContent.vue` (+5 -5) 📝 `resources/assets/js/components/layout/main-wrapper/Sidebar.vue` (+4 -6) 📝 `resources/assets/js/components/playlist/CreatePlaylistFolderForm.vue` (+7 -7) 📝 `resources/assets/js/components/playlist/CreatePlaylistForm.vue` (+9 -9) 📝 `resources/assets/js/components/playlist/EditPlaylistFolderForm.vue` (+7 -6) 📝 `resources/assets/js/components/playlist/EditPlaylistForm.vue` (+7 -6) 📝 `resources/assets/js/components/playlist/PlaylistFolderContextMenu.vue` (+5 -7) 📝 `resources/assets/js/components/playlist/PlaylistSidebarItem.vue` (+4 -5) 📝 `resources/assets/js/components/playlist/PlaylistSidebarList.vue` (+1 -4) 📝 `resources/assets/js/components/playlist/smart-playlist/CreateSmartPlaylistForm.vue` (+10 -10) 📝 `resources/assets/js/components/playlist/smart-playlist/EditSmartPlaylistForm.vue` (+7 -7) 📝 `resources/assets/js/components/profile-preferences/ProfileForm.vue` (+10 -9) 📝 `resources/assets/js/components/screens/AlbumListScreen.vue` (+2 -2) _...and 39 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:21 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1799

No description provided.

Rows
Columns