[PR #1594] [MERGED] feat: use dialog element for overlay component #1797

Closed
opened 2026-02-26 03:32:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1594
Author: @phanan
Created: 11/18/2022
Status: Merged
Merged: 11/18/2022
Merged by: @phanan

Base: masterHead: feat/overlay-dialog


📝 Commits (1)

  • 4b7ecf4 feat: use dialog element for overlay component

📊 Changes

7 files changed (+67 additions, -74 deletions)

View changed files

📝 resources/assets/js/__tests__/setup.ts (+14 -6)
📝 resources/assets/js/components/ui/Overlay.spec.ts (+8 -5)
📝 resources/assets/js/components/ui/Overlay.vue (+22 -20)
📝 resources/assets/js/components/ui/__snapshots__/Overlay.spec.ts.snap (+23 -28)
📝 resources/assets/js/symbols.ts (+0 -1)
📝 resources/assets/js/types.d.ts (+0 -1)
📝 resources/assets/sass/partials/_shared.scss (+0 -13)

📄 Description

No description provided


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1594 **Author:** [@phanan](https://github.com/phanan) **Created:** 11/18/2022 **Status:** ✅ Merged **Merged:** 11/18/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/overlay-dialog` --- ### 📝 Commits (1) - [`4b7ecf4`](https://github.com/koel/koel/commit/4b7ecf49ad072064246aac945c2b8a8dcc7289bc) feat: use dialog element for overlay component ### 📊 Changes **7 files changed** (+67 additions, -74 deletions) <details> <summary>View changed files</summary> 📝 `resources/assets/js/__tests__/setup.ts` (+14 -6) 📝 `resources/assets/js/components/ui/Overlay.spec.ts` (+8 -5) 📝 `resources/assets/js/components/ui/Overlay.vue` (+22 -20) 📝 `resources/assets/js/components/ui/__snapshots__/Overlay.spec.ts.snap` (+23 -28) 📝 `resources/assets/js/symbols.ts` (+0 -1) 📝 `resources/assets/js/types.d.ts` (+0 -1) 📝 `resources/assets/sass/partials/_shared.scss` (+0 -13) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1797
No description provided.