[PR #1591] [MERGED] feat: make event bus (emitter) type-safe #1796

New issue

Closed

opened 2026-02-26 03:32:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 03:32:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1591
Author: @phanan
Created: 11/15/2022
Status: ✅ Merged
Merged: 11/15/2022
Merged by: @phanan

Base: master ← Head: feat/eventbus-revamp

📝 Commits (1)

15e4133 feat: make event bus (emitter) typesafe

📊 Changes

24 files changed (+125 additions, -234 deletions)

View changed files

📝 package.json (+1 -0)
📝 resources/assets/js/components/album/AlbumContextMenu.vue (+1 -1)
📝 resources/assets/js/components/artist/ArtistContextMenu.vue (+1 -1)
📝 resources/assets/js/components/layout/ModalWrapper.vue (+14 -21)
📝 resources/assets/js/components/layout/main-wrapper/Sidebar.vue (+5 -7)
📝 resources/assets/js/components/playlist/CreateNewPlaylistContextMenu.vue (+1 -6)
📝 resources/assets/js/components/playlist/PlaylistContextMenu.vue (+4 -6)
📝 resources/assets/js/components/playlist/PlaylistFolderContextMenu.vue (+1 -1)
📝 resources/assets/js/components/screens/HomeScreen.vue (+2 -1)
📝 resources/assets/js/components/screens/PlaylistScreen.vue (+3 -5)
📝 resources/assets/js/components/screens/QueueScreen.vue (+3 -3)
📝 resources/assets/js/components/screens/YouTubeScreen.vue (+2 -2)
📝 resources/assets/js/components/screens/search/SearchExcerptsScreen.vue (+5 -9)
📝 resources/assets/js/components/song/SongContextMenu.vue (+1 -1)
📝 resources/assets/js/components/ui/ContextMenuBase.vue (+1 -3)
📝 resources/assets/js/components/ui/Overlay.vue (+2 -4)
📝 resources/assets/js/components/ui/SearchForm.vue (+3 -5)
📝 resources/assets/js/components/utils/GlobalEventListeners.ts (+15 -24)
📝 resources/assets/js/composables/useSongList.ts (+1 -3)
📝 resources/assets/js/config/events.ts (+48 -45)

...and 4 more files

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1591 **Author:** [@phanan](https://github.com/phanan) **Created:** 11/15/2022 **Status:** ✅ Merged **Merged:** 11/15/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/eventbus-revamp` --- ### 📝 Commits (1) - [`15e4133`](https://github.com/koel/koel/commit/15e413303a86b7d56a87419b00ca3343294f6267) feat: make event bus (emitter) typesafe ### 📊 Changes **24 files changed** (+125 additions, -234 deletions) <details> <summary>View changed files</summary> 📝 `package.json` (+1 -0) 📝 `resources/assets/js/components/album/AlbumContextMenu.vue` (+1 -1) 📝 `resources/assets/js/components/artist/ArtistContextMenu.vue` (+1 -1) 📝 `resources/assets/js/components/layout/ModalWrapper.vue` (+14 -21) 📝 `resources/assets/js/components/layout/main-wrapper/Sidebar.vue` (+5 -7) 📝 `resources/assets/js/components/playlist/CreateNewPlaylistContextMenu.vue` (+1 -6) 📝 `resources/assets/js/components/playlist/PlaylistContextMenu.vue` (+4 -6) 📝 `resources/assets/js/components/playlist/PlaylistFolderContextMenu.vue` (+1 -1) 📝 `resources/assets/js/components/screens/HomeScreen.vue` (+2 -1) 📝 `resources/assets/js/components/screens/PlaylistScreen.vue` (+3 -5) 📝 `resources/assets/js/components/screens/QueueScreen.vue` (+3 -3) 📝 `resources/assets/js/components/screens/YouTubeScreen.vue` (+2 -2) 📝 `resources/assets/js/components/screens/search/SearchExcerptsScreen.vue` (+5 -9) 📝 `resources/assets/js/components/song/SongContextMenu.vue` (+1 -1) 📝 `resources/assets/js/components/ui/ContextMenuBase.vue` (+1 -3) 📝 `resources/assets/js/components/ui/Overlay.vue` (+2 -4) 📝 `resources/assets/js/components/ui/SearchForm.vue` (+3 -5) 📝 `resources/assets/js/components/utils/GlobalEventListeners.ts` (+15 -24) 📝 `resources/assets/js/composables/useSongList.ts` (+1 -3) 📝 `resources/assets/js/config/events.ts` (+48 -45) _...and 4 more files_ </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 03:32:20 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 03:32:38 +03:00

[PR #1797] [MERGED] feat: implement and use new confg key for trusted hosts #1875

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#1796

No description provided.

Rows
Columns