mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[PR #1592] [MERGED] feat: use a composition token #1795
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#1795
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/koel/koel/pull/1592
Author: @phanan
Created: 11/16/2022
Status: ✅ Merged
Merged: 11/16/2022
Merged by: @phanan
Base:
master← Head:feat/composition-token📝 Commits (1)
442eca9feat: use a composition token📊 Changes
24 files changed (+319 additions, -45 deletions)
View changed files
📝
app/Http/Controllers/API/AuthController.php(+9 -3)📝
app/Http/Controllers/API/ProfileController.php(+4 -1)📝
app/Http/Kernel.php(+2 -0)➕
app/Http/Middleware/AudioAuthenticate.php(+17 -0)📝
app/Http/Middleware/Authenticate.php(+8 -12)📝
app/Models/User.php(+2 -0)📝
app/Providers/AuthServiceProvider.php(+3 -1)📝
app/Services/TokenManager.php(+35 -3)➕
app/Values/CompositionToken.php(+26 -0)📝
resources/assets/js/App.vue(+1 -1)📝
resources/assets/js/components/album/AlbumTrackListItem.vue(+1 -1)📝
resources/assets/js/components/profile-preferences/LastfmIntegration.vue(+1 -1)📝
resources/assets/js/remote/App.vue(+1 -1)📝
resources/assets/js/services/authService.spec.ts(+3 -3)📝
resources/assets/js/services/authService.ts(+18 -6)📝
resources/assets/js/services/downloadService.ts(+1 -1)📝
resources/assets/js/services/http.ts(+5 -2)📝
resources/assets/js/services/socketService.ts(+1 -1)📝
resources/assets/js/stores/songStore.spec.ts(+3 -3)📝
resources/assets/js/stores/songStore.ts(+2 -2)...and 4 more files
📄 Description
Use a composition token (API + web audio tokens) to prevent the API token from being logged by server and proxy software.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.