[PR #1592] [MERGED] feat: use a composition token #1795

Closed
opened 2026-02-26 03:32:20 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/koel/koel/pull/1592
Author: @phanan
Created: 11/16/2022
Status: Merged
Merged: 11/16/2022
Merged by: @phanan

Base: masterHead: feat/composition-token


📝 Commits (1)

  • 442eca9 feat: use a composition token

📊 Changes

24 files changed (+319 additions, -45 deletions)

View changed files

📝 app/Http/Controllers/API/AuthController.php (+9 -3)
📝 app/Http/Controllers/API/ProfileController.php (+4 -1)
📝 app/Http/Kernel.php (+2 -0)
app/Http/Middleware/AudioAuthenticate.php (+17 -0)
📝 app/Http/Middleware/Authenticate.php (+8 -12)
📝 app/Models/User.php (+2 -0)
📝 app/Providers/AuthServiceProvider.php (+3 -1)
📝 app/Services/TokenManager.php (+35 -3)
app/Values/CompositionToken.php (+26 -0)
📝 resources/assets/js/App.vue (+1 -1)
📝 resources/assets/js/components/album/AlbumTrackListItem.vue (+1 -1)
📝 resources/assets/js/components/profile-preferences/LastfmIntegration.vue (+1 -1)
📝 resources/assets/js/remote/App.vue (+1 -1)
📝 resources/assets/js/services/authService.spec.ts (+3 -3)
📝 resources/assets/js/services/authService.ts (+18 -6)
📝 resources/assets/js/services/downloadService.ts (+1 -1)
📝 resources/assets/js/services/http.ts (+5 -2)
📝 resources/assets/js/services/socketService.ts (+1 -1)
📝 resources/assets/js/stores/songStore.spec.ts (+3 -3)
📝 resources/assets/js/stores/songStore.ts (+2 -2)

...and 4 more files

📄 Description

Use a composition token (API + web audio tokens) to prevent the API token from being logged by server and proxy software.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/koel/koel/pull/1592 **Author:** [@phanan](https://github.com/phanan) **Created:** 11/16/2022 **Status:** ✅ Merged **Merged:** 11/16/2022 **Merged by:** [@phanan](https://github.com/phanan) **Base:** `master` ← **Head:** `feat/composition-token` --- ### 📝 Commits (1) - [`442eca9`](https://github.com/koel/koel/commit/442eca976478e2f27f5951afc14925a5467f8523) feat: use a composition token ### 📊 Changes **24 files changed** (+319 additions, -45 deletions) <details> <summary>View changed files</summary> 📝 `app/Http/Controllers/API/AuthController.php` (+9 -3) 📝 `app/Http/Controllers/API/ProfileController.php` (+4 -1) 📝 `app/Http/Kernel.php` (+2 -0) ➕ `app/Http/Middleware/AudioAuthenticate.php` (+17 -0) 📝 `app/Http/Middleware/Authenticate.php` (+8 -12) 📝 `app/Models/User.php` (+2 -0) 📝 `app/Providers/AuthServiceProvider.php` (+3 -1) 📝 `app/Services/TokenManager.php` (+35 -3) ➕ `app/Values/CompositionToken.php` (+26 -0) 📝 `resources/assets/js/App.vue` (+1 -1) 📝 `resources/assets/js/components/album/AlbumTrackListItem.vue` (+1 -1) 📝 `resources/assets/js/components/profile-preferences/LastfmIntegration.vue` (+1 -1) 📝 `resources/assets/js/remote/App.vue` (+1 -1) 📝 `resources/assets/js/services/authService.spec.ts` (+3 -3) 📝 `resources/assets/js/services/authService.ts` (+18 -6) 📝 `resources/assets/js/services/downloadService.ts` (+1 -1) 📝 `resources/assets/js/services/http.ts` (+5 -2) 📝 `resources/assets/js/services/socketService.ts` (+1 -1) 📝 `resources/assets/js/stores/songStore.spec.ts` (+3 -3) 📝 `resources/assets/js/stores/songStore.ts` (+2 -2) _...and 4 more files_ </details> ### 📄 Description Use a composition token (API + web audio tokens) to prevent the API token from being logged by server and proxy software. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 03:32:20 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#1795
No description provided.